netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 14/14] net: txgbe: Support sysfs file system
Date: Thu, 12 May 2022 13:43:13 +0200	[thread overview]
Message-ID: <Ynzy0ZOJh68nI3dx@lunn.ch> (raw)
In-Reply-To: <20220511032659.641834-15-jiawenwu@trustnetic.com>

On Wed, May 11, 2022 at 11:26:59AM +0800, Jiawen Wu wrote:
> Add support for sysfs file system.

Please always Cc: the hwmon maintainers for hwmon patches.

> +	txgbe_hwmon->device =
> +			hwmon_device_register(pci_dev_to_dev(adapter->pdev));

I _think_ the preferred interface is
hwmon_device_register_with_groups() or
hwmon_device_register_with_info(). The hwmon maintainer will tell you.

	Andrew

  reply	other threads:[~2022-05-12 11:43 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11  3:26 [PATCH net-next 00/14] Wangxun 10 Gigabit Ethernet Driver Jiawen Wu
2022-05-11  3:26 ` [PATCH net-next 01/14] net: txgbe: Add build support for txgbe ethernet driver Jiawen Wu
2022-05-12  0:38   ` kernel test robot
2022-05-12 15:52   ` Andrew Lunn
2022-05-11  3:26 ` [PATCH net-next 02/14] net: txgbe: Add hardware initialization Jiawen Wu
2022-05-12  5:15   ` kernel test robot
2022-05-11  3:26 ` [PATCH net-next 03/14] net: txgbe: Add operations to interact with firmware Jiawen Wu
2022-05-11  3:26 ` [PATCH net-next 04/14] net: txgbe: Add PHY interface support Jiawen Wu
2022-05-12 12:21   ` Andrew Lunn
2022-05-11  3:26 ` [PATCH net-next 05/14] net: txgbe: Add interrupt support Jiawen Wu
2022-05-11  3:26 ` [PATCH net-next 06/14] net: txgbe: Support to receive and tranmit packets Jiawen Wu
2022-05-11  3:26 ` [PATCH net-next 07/14] net: txgbe: Support flow control Jiawen Wu
2022-05-11  3:26 ` [PATCH net-next 08/14] net: txgbe: Support flow director Jiawen Wu
2022-05-11  3:26 ` [PATCH net-next 09/14] net: txgbe: Support PTP Jiawen Wu
2022-05-11  3:26 ` [PATCH net-next 10/14] net: txgbe: Add ethtool support Jiawen Wu
2022-05-12 12:11   ` Andrew Lunn
2022-05-11  3:26 ` [PATCH net-next 11/14] net: txgbe: Support PCIe recovery Jiawen Wu
2022-05-11  3:26 ` [PATCH net-next 12/14] net: txgbe: Support power management Jiawen Wu
2022-05-11  3:26 ` [PATCH net-next 13/14] net: txgbe: Support debug filesystem Jiawen Wu
2022-05-12 11:56   ` Andrew Lunn
2022-05-11  3:26 ` [PATCH net-next 14/14] net: txgbe: Support sysfs file system Jiawen Wu
2022-05-12 11:43   ` Andrew Lunn [this message]
2022-05-12  0:54 ` [PATCH net-next 00/14] Wangxun 10 Gigabit Ethernet Driver Jakub Kicinski
     [not found]   ` <004401d865e4$c3073d10$4915b730$@trustnetic.com>
2022-05-12 15:57     ` Jakub Kicinski
2022-05-12 22:06       ` Andrew Lunn
     [not found]         ` <001201d86671$61c86410$25592c30$@trustnetic.com>
2022-05-13 12:27           ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ynzy0ZOJh68nI3dx@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=jiawenwu@trustnetic.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).