From: Leon Romanovsky <leon@kernel.org>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org, Raed Salem <raeds@nvidia.com>,
ipsec-devel <devel@linux-ipsec.org>
Subject: Re: [PATCH ipsec-next 3/6] xfrm: add an interface to offload policy
Date: Mon, 16 May 2022 08:18:15 +0300 [thread overview]
Message-ID: <YoHel1LqqtNe0U01@unreal> (raw)
In-Reply-To: <20220513144432.GK680067@gauss3.secunet.de>
On Fri, May 13, 2022 at 04:44:32PM +0200, Steffen Klassert wrote:
> On Tue, May 10, 2022 at 01:36:54PM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@nvidia.com>
> >
> > +int xfrm_dev_policy_add(struct net *net, struct xfrm_policy *xp,
> > + struct xfrm_user_offload *xuo, u8 dir)
> > +{
> > + struct xfrm_dev_offload *xdo = &xp->xdo;
> > + struct net_device *dev;
> > + int err;
> > +
> > + if (!xuo->flags || xuo->flags & ~XFRM_OFFLOAD_FULL)
> > + /* We support only Full offload mode and it means
> > + * that user must set XFRM_OFFLOAD_FULL bit.
> > + */
> > + return -EINVAL;
>
> Minor nit: Please add the comment before the 'if' statement or
> use braces.
Sure, will do.
next prev parent reply other threads:[~2022-05-16 5:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 10:36 [PATCH ipsec-next 0/6] Extend XFRM core to allow full offload configuration Leon Romanovsky
2022-05-10 10:36 ` [PATCH ipsec-next 1/6] xfrm: add new full offload flag Leon Romanovsky
2022-05-10 10:36 ` [PATCH ipsec-next 2/6] xfrm: allow state full offload mode Leon Romanovsky
2022-05-10 10:36 ` [PATCH ipsec-next 3/6] xfrm: add an interface to offload policy Leon Romanovsky
2022-05-13 14:44 ` Steffen Klassert
2022-05-16 5:18 ` Leon Romanovsky [this message]
2022-05-10 10:36 ` [PATCH ipsec-next 4/6] xfrm: add TX datapath support for IPsec full offload mode Leon Romanovsky
2022-05-13 14:56 ` Steffen Klassert
2022-05-16 5:44 ` Leon Romanovsky
2022-05-18 7:49 ` Steffen Klassert
2022-05-24 18:30 ` Leon Romanovsky
2022-05-10 10:36 ` [PATCH ipsec-next 5/6] xfrm: add RX datapath protection " Leon Romanovsky
2022-05-13 15:02 ` Steffen Klassert
2022-05-16 5:29 ` Leon Romanovsky
2022-05-18 8:02 ` Steffen Klassert
2022-05-10 10:36 ` [PATCH ipsec-next 6/6] xfrm: enforce separation between priorities of HW/SW policies Leon Romanovsky
2022-05-13 15:07 ` Steffen Klassert
2022-05-16 5:17 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoHel1LqqtNe0U01@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=devel@linux-ipsec.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=raeds@nvidia.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).