Re: [PATCH RESEND net] bonding: fix missed rcu protection

[Hangbin Liu <liuhangbin@gmail.com>]

On Tue, May 17, 2022 at 09:24:00AM +0200, Paolo Abeni wrote:
> On Tue, 2022-05-17 at 11:42 +0800, Hangbin Liu wrote:
> > On Mon, May 16, 2022 at 06:10:28PM -0700, Jakub Kicinski wrote:
> > > Can't ->get_ts_info sleep now? It'd be a little sad to force it 
> > > to be atomic just because of one upper dev trying to be fancy.
> > > Maybe all we need to do is to take a ref on the real_dev?
> > 
> > Do you mean
> > 
> > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> > index 38e152548126..b60450211579 100644
> > --- a/drivers/net/bonding/bond_main.c
> > +++ b/drivers/net/bonding/bond_main.c
> > @@ -5591,16 +5591,20 @@ static int bond_ethtool_get_ts_info(struct net_device *bond_dev,
> >  	const struct ethtool_ops *ops;
> >  	struct net_device *real_dev;
> >  	struct phy_device *phydev;
> > +	int ret = 0;
> >  
> 
> You additionally need something alike the following:
> 
> 	rcu_read_lock();

Thanks Paolo, I only thought the real_dev ref and forgot the initial problem
is the rcu warning...

Hangbin