Re: [PATCH v2 net-next 11/15] net: ethernet: mtk_eth_soc: introduce device register map

Lorenzo Bianconi
2022-05-18T09:48:53Z

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

> On Mon, 16 May 2022 18:06:38 +0200 Lorenzo Bianconi wrote:
> > /* PDMA RX Base Pointer Register */
> > -#define MTK_PRX_BASE_PTR0 0x900
> > +#define MTK_PRX_BASE_PTR0 (eth->soc->reg_map[MTK_PDMA_BASE] + 0x100)
> > #define MTK_PRX_BASE_PTR_CFG(x) (MTK_PRX_BASE_PTR0 + (x * 0x10))
>
> Implicit macro arguments are really unpleasant for people doing
> tree-wide changes or otherwise unfamiliar with the driver.
>
> Nothing we can do to avoid this?

I used this approach in order to have just few changes in the codebase. I guess the best
option would be to explicitly add eth parameter to the register macros, what do you think?

Regards,
Lorenzo

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]