Re: [PATCH v2 net-next 10/15] net: ethernet: mtk_eth_soc: rely on rxd_size field in mtk_rx_alloc/mtk_rx_clean

Jakub Kicinski
2022-05-18T01:39:43Z

On Mon, 16 May 2022 18:06:37 +0200 Lorenzo Bianconi wrote:
> +
> + rxd = (void *)ring->dma + i * eth->soc->txrx.rxd_size;
> + rxd->rxd1 = (unsigned int)dma_addr;
>
> if (MTK_HAS_CAPS(eth->soc->caps, MTK_SOC_MT7628))
> - ring->dma[i].rxd2 = RX_DMA_LSO;
> + rxd->rxd2 = RX_DMA_LSO;
> else
> - ring->dma[i].rxd2 = RX_DMA_PLEN0(ring->buf_size);
> + rxd->rxd2 = RX_DMA_PLEN0(ring->buf_size);
> +
> + rxd->rxd3 = 0;
> + rxd->rxd4 = 0;

The clearing of rxd3/rxd4 should probably have been mentioned in the
commit message. It does not seem related to descriptor size.