Re: [PATCH v2 net-next 04/15] net: ethernet: mtk_eth_soc: add txd_size to mtk_soc_data

Lorenzo Bianconi
2022-05-18T08:30:01Z

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

> On Mon, 16 May 2022 18:06:31 +0200 Lorenzo Bianconi wrote:
> > eth->scratch_ring = dma_alloc_coherent(eth->dma_dev,
> > - cnt * sizeof(struct mtk_tx_dma),
> > + cnt * soc->txrx.txd_size,
> > &eth->phy_scratch_ring,
> > GFP_ATOMIC);
> > if (unlikely(!eth->scratch_ring))
> > return -ENOMEM;
> >
> > - eth->scratch_head = kcalloc(cnt, MTK_QDMA_PAGE_SIZE,
> > - GFP_KERNEL);
> > + eth->scratch_head = kcalloc(cnt, MTK_QDMA_PAGE_SIZE, GFP_KERNEL);
>
> Unrelated, but GFP_ATOMIC right next to GFP_KERNEL caught my attention.

ack, mtk_init_fq_dma() is run by mtk_open() so it is ok to use GFP_KERNEL. I
will fix it in v3.

Regards,
Lorenzo

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]