* [PATCH] ath11k: fix IRQ affinity warning on shutdown
@ 2022-05-23 14:32 Johan Hovold
2022-05-23 14:47 ` Johan Hovold
2022-05-30 11:24 ` Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Johan Hovold @ 2022-05-23 14:32 UTC (permalink / raw)
To: Kalle Valo
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
ath11k, linux-wireless, netdev, linux-kernel, Johan Hovold
Make sure to clear the IRQ affinity hint also on shutdown to avoid
triggering a WARN_ON_ONCE() in __free_irq() when stopping MHI while
using a single MSI vector.
Fixes: e94b07493da3 ("ath11k: Set IRQ affinity to CPU0 in case of one MSI vector")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/net/wireless/ath/ath11k/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/ath/ath11k/pci.c b/drivers/net/wireless/ath/ath11k/pci.c
index dedf1b88ddf6..487a303b3077 100644
--- a/drivers/net/wireless/ath/ath11k/pci.c
+++ b/drivers/net/wireless/ath/ath11k/pci.c
@@ -920,7 +920,9 @@ static void ath11k_pci_remove(struct pci_dev *pdev)
static void ath11k_pci_shutdown(struct pci_dev *pdev)
{
struct ath11k_base *ab = pci_get_drvdata(pdev);
+ struct ath11k_pci *ab_pci = ath11k_pci_priv(ab);
+ ath11k_pci_set_irq_affinity_hint(ab_pci, NULL);
ath11k_pci_power_down(ab);
}
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ath11k: fix IRQ affinity warning on shutdown
2022-05-23 14:32 [PATCH] ath11k: fix IRQ affinity warning on shutdown Johan Hovold
@ 2022-05-23 14:47 ` Johan Hovold
2022-05-23 19:03 ` Kalle Valo
2022-05-30 11:24 ` Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Johan Hovold @ 2022-05-23 14:47 UTC (permalink / raw)
To: Johan Hovold
Cc: Kalle Valo, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, ath11k, linux-wireless, netdev, linux-kernel
On Mon, May 23, 2022 at 04:32:58PM +0200, Johan Hovold wrote:
> Make sure to clear the IRQ affinity hint also on shutdown to avoid
> triggering a WARN_ON_ONCE() in __free_irq() when stopping MHI while
> using a single MSI vector.
Forgot the tested-on tag, sorry.
Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
> Fixes: e94b07493da3 ("ath11k: Set IRQ affinity to CPU0 in case of one MSI vector")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Let me know if I should resend.
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ath11k: fix IRQ affinity warning on shutdown
2022-05-23 14:47 ` Johan Hovold
@ 2022-05-23 19:03 ` Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2022-05-23 19:03 UTC (permalink / raw)
To: Johan Hovold
Cc: Johan Hovold, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, ath11k, linux-wireless, netdev, linux-kernel
Johan Hovold <johan@kernel.org> writes:
> On Mon, May 23, 2022 at 04:32:58PM +0200, Johan Hovold wrote:
>> Make sure to clear the IRQ affinity hint also on shutdown to avoid
>> triggering a WARN_ON_ONCE() in __free_irq() when stopping MHI while
>> using a single MSI vector.
>
> Forgot the tested-on tag, sorry.
>
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
Thanks, added in the pending branch.
>> Fixes: e94b07493da3 ("ath11k: Set IRQ affinity to CPU0 in case of one MSI vector")
>> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
>
> Let me know if I should resend.
No need, I can easily edit commit logs.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath11k: fix IRQ affinity warning on shutdown
2022-05-23 14:32 [PATCH] ath11k: fix IRQ affinity warning on shutdown Johan Hovold
2022-05-23 14:47 ` Johan Hovold
@ 2022-05-30 11:24 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2022-05-30 11:24 UTC (permalink / raw)
To: Johan Hovold
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
ath11k, linux-wireless, netdev, linux-kernel, Johan Hovold
Johan Hovold <johan+linaro@kernel.org> wrote:
> Make sure to clear the IRQ affinity hint also on shutdown to avoid
> triggering a WARN_ON_ONCE() in __free_irq() when stopping MHI while
> using a single MSI vector.
>
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
>
> Fixes: e94b07493da3 ("ath11k: Set IRQ affinity to CPU0 in case of one MSI vector")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
3bd0c69653ac ath11k: fix IRQ affinity warning on shutdown
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220523143258.24818-1-johan+linaro@kernel.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-30 11:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-23 14:32 [PATCH] ath11k: fix IRQ affinity warning on shutdown Johan Hovold
2022-05-23 14:47 ` Johan Hovold
2022-05-23 19:03 ` Kalle Valo
2022-05-30 11:24 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).