From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AB59C433F5 for ; Fri, 27 May 2022 16:44:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243579AbiE0Qoo (ORCPT ); Fri, 27 May 2022 12:44:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238676AbiE0Qon (ORCPT ); Fri, 27 May 2022 12:44:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F8E3EAD1D for ; Fri, 27 May 2022 09:44:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ADD0B61DF6 for ; Fri, 27 May 2022 16:44:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9627AC385B8; Fri, 27 May 2022 16:44:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653669882; bh=4TDRmopppv3+yFUZX9BljdSuGR1hFRNAsK/kBdSdXQs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tinJccVszwuYh2tlztIJq4pUnb8fPl49njA5dwS0ylEj/aDkjB+E+rsljbdoE809I gI010z8oZVxQuhWqsrVQEgMcVisOKy9QJVUb7ai76zJs6jDGwoI8APb7qVFhIZQhIQ Ew4u5MsGrrYk4UeFmrmVIZC54rLWXl2gP5jZbp92sPkmAkGkq/8szvYlSgt0nQHh3M mAWqtoos35vTnmQCgcaGvNbVH1A4p3X5D+vAWM9W6WuueRdDqrmcOXEWmYdeDtF7Zj p/VAqyy5TRc8lIJBQJDmA0w7yY6ab++5KFeoFsfVzEKUvlmmAxEnXeJztOE3U2FSRQ BKVX78PMgfnyg== Date: Fri, 27 May 2022 19:44:37 +0300 From: Leon Romanovsky To: Jiawen Wu Cc: netdev@vger.kernel.org Subject: Re: [PATCH net-next v3] net: txgbe: Add build support for txgbe Message-ID: References: <20220527063157.486686-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220527063157.486686-1-jiawenwu@trustnetic.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, May 27, 2022 at 02:31:57PM +0800, Jiawen Wu wrote: > Add doc build infrastructure for txgbe driver. > Initialize PCI memory space for WangXun 10 Gigabit Ethernet devices. > > Signed-off-by: Jiawen Wu > --- > .../device_drivers/ethernet/index.rst | 1 + > .../device_drivers/ethernet/wangxun/txgbe.rst | 20 ++ > MAINTAINERS | 7 + > drivers/net/ethernet/Kconfig | 1 + > drivers/net/ethernet/Makefile | 1 + > drivers/net/ethernet/wangxun/Kconfig | 32 +++ > drivers/net/ethernet/wangxun/Makefile | 6 + > drivers/net/ethernet/wangxun/txgbe/Makefile | 9 + > drivers/net/ethernet/wangxun/txgbe/txgbe.h | 27 ++ > .../net/ethernet/wangxun/txgbe/txgbe_main.c | 241 ++++++++++++++++++ > .../net/ethernet/wangxun/txgbe/txgbe_type.h | 65 +++++ > 11 files changed, 410 insertions(+) > create mode 100644 Documentation/networking/device_drivers/ethernet/wangxun/txgbe.rst > create mode 100644 drivers/net/ethernet/wangxun/Kconfig > create mode 100644 drivers/net/ethernet/wangxun/Makefile > create mode 100644 drivers/net/ethernet/wangxun/txgbe/Makefile > create mode 100644 drivers/net/ethernet/wangxun/txgbe/txgbe.h > create mode 100644 drivers/net/ethernet/wangxun/txgbe/txgbe_main.c > create mode 100644 drivers/net/ethernet/wangxun/txgbe/txgbe_type.h <...> > +/** > + * txgbe_sw_init - Initialize general software structures (struct txgbe_adapter) > + * @adapter: board private structure to initialize > + * > + * txgbe_sw_init initializes the Adapter private data structure. > + * Fields are initialized based on PCI device information and > + * OS network device settings (MTU size). > + **/ > +static int txgbe_sw_init(struct txgbe_adapter *adapter) > +{ > + struct txgbe_hw *hw = &adapter->hw; > + struct pci_dev *pdev = adapter->pdev; > + > + /* PCI config space info */ > + hw->vendor_id = pdev->vendor; > + hw->device_id = pdev->device; > + hw->revision_id = pdev->revision; > + hw->subsystem_vendor_id = pdev->subsystem_vendor; > + hw->subsystem_device_id = pdev->subsystem_device; > + > + return 0; > +} You are setting this data, but not using it. I'm not sure that to cache this data is even correct thing to do in a first place. > + <...> > + pci_set_master(pdev); > + /* errata 16 */ > + pcie_capability_clear_and_set_word(pdev, PCI_EXP_DEVCTL, > + PCI_EXP_DEVCTL_READRQ, > + 0x1000); Why do you need this in probe function and not as PCI quirk? Thanks