Re: [PATCH net] bonding: show NS IPv6 targets in proc master info

[Hangbin Liu <liuhangbin@gmail.com>]

On Sun, May 29, 2022 at 11:35:21PM -0400, Jonathan Toppins wrote:
> > Yes, I didn't protect the code if if could be build without CONFIG_IPV6.
> > e.g. function bond_get_targets_ip6(). Do you think if I should also
> > add the condition for bond_get_targets_ip6() and ns_targets in struct
> > bond_params?
> 
> Yes, if the code that will use the entries in `struct bonding` and `struct
> bond_params` is going to be compiled out these entries should be compiled
> out as well.

OK, I will fix it.
> 
> Also, I was looking over the code in bond_options.c:bond_opts, and the entry
> `BOND_OPT_NS_TARGETS` is the only bonding option that will be left
> uninitialized if IPv6 is disabled. Does the bonding options infra handle
> this correctly or do you need a dummy set of values when IPv6 is disabled?
> 

The only entry to set ns_target is via netlink, which has protected by
CONFIG_IPV6. So I think it's safe now. To make it more safer. I will add
a dummy set.

Thanks
Hangbin