Re: [PATCH net-next 00/11] mlxsw: extend line card model by devices and info

Ido Schimmel
2022-04-25T19:40:09Z

On Mon, Apr 25, 2022 at 09:00:21AM -0700, Jakub Kicinski wrote:
> On Mon, 25 Apr 2022 06:44:20 +0300 Ido Schimmel wrote:
> > This patchset is extending the line card model by three items:
> > 1) line card devices
> > 2) line card info
> > 3) line card device info
> >
> > First three patches are introducing the necessary changes in devlink
> > core.
> >
> > Then, all three extensions are implemented in mlxsw alongside with
> > selftest.
>
> :/ what is a line card device? You must provide document what you're
> doing, this:
>
> .../networking/devlink/devlink-linecard.rst | 4 +
>
> is not enough.
>
> How many operations and attributes are you going to copy&paste?
>
> Is linking devlink instances into a hierarchy a better approach?

In this particular case, these devices are gearboxes. They are running
their own firmware and we want user space to be able to query and update
the running firmware version.

The idea (implemented in the next patchset) is to let these devices
expose their own "component name", which can then be plugged into the
existing flash command:

$ devlink lc show pci/0000:01:00.0 lc 8
pci/0000:01:00.0:
lc 8 state active type 16x100G
supported_types:
16x100G
devices:
device 0 flashable true component lc8_dev0
device 1 flashable false
device 2 flashable false
device 3 flashable false
$ devlink dev flash pci/0000:01:00.0 file some_file.mfa2 component lc8_dev0

Registering a separate devlink instance for these devices sounds like an
overkill to me. If you are not OK with a separate command (e.g.,
DEVLINK_CMD_LINECARD_INFO_GET), then extending DEVLINK_CMD_INFO_GET is
also an option. We discussed this during internal review, but felt that
the current approach is cleaner.

> Would you mind if I revert this?

I can't stop you, but keep in mind that it's already late here and that
tomorrow I'm AFK (reserve duty) and won't be able to tag it. Jiri should
be available to continue this discussion tomorrow morning, so probably
best to wait for his feedback.