netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leonro@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Boris Pismenny <borisp@nvidia.com>, <netdev@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"Saeed Mahameed" <saeedm@nvidia.com>
Subject: Re: [PATCH] MAINTAINERS: adjust MELLANOX ETHERNET INNOVA DRIVERS to TLS support removal
Date: Wed, 1 Jun 2022 21:08:06 +0300	[thread overview]
Message-ID: <YperBiCh1rkKDmSR@unreal> (raw)
In-Reply-To: <20220601103032.28d14fc4@kicinski-fedora-PC1C0HJN>

On Wed, Jun 01, 2022 at 10:30:39AM -0700, Jakub Kicinski wrote:
> On Wed, 1 Jun 2022 13:18:12 +0300 Leon Romanovsky wrote:
> > On Wed, Jun 01, 2022 at 06:57:38AM +0200, Lukas Bulwahn wrote:
> > > Commit 40379a0084c2 ("net/mlx5_fpga: Drop INNOVA TLS support") removes all
> > > files in the directory drivers/net/ethernet/mellanox/mlx5/core/accel/, but
> > > misses to adjust its reference in MAINTAINERS.
> > > 
> > > Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
> > > broken reference.
> > > 
> > > Remove the file entry to the removed directory in MELLANOX ETHERNET INNOVA
> > > DRIVERS.
> > > 
> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > > ---
> > > Leon, please pick this minor non-urgent clean-up patch on top of the commit
> > > above.  
> > 
> > Thanks, we will submit it once net-next will be open.
> 
> It should go via net FWIW.

I'm slightly confused here.

According to net policy, the patches that goes there should have Fixes
line, but Fixes lines are added for bugs [1].

This forgotten line in MAINTAINERS doesn't cause to any harm to
users/developers.

So when should I put Fixes line in netdev?

[1] https://lore.kernel.org/netdev/20211208070842.0ace6747@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/

Thanks

  reply	other threads:[~2022-06-01 18:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01  4:57 [PATCH] MAINTAINERS: adjust MELLANOX ETHERNET INNOVA DRIVERS to TLS support removal Lukas Bulwahn
2022-06-01 10:18 ` Leon Romanovsky
2022-06-01 17:30   ` Jakub Kicinski
2022-06-01 18:08     ` Leon Romanovsky [this message]
2022-06-01 19:26       ` Jakub Kicinski
2022-06-02  6:13         ` Leon Romanovsky
2022-06-10  5:20 ` patchwork-bot+netdevbpf
2022-06-10  5:56   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YperBiCh1rkKDmSR@unreal \
    --to=leonro@nvidia.com \
    --cc=borisp@nvidia.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).