From: Simon Horman <simon.horman@corigine.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
oss-drivers@corigine.com, netdev@vger.kernel.org
Subject: Re: [PATCH] nfp: Remove kernel.h when not needed
Date: Sat, 4 Jun 2022 11:17:11 +0200 [thread overview]
Message-ID: <YpsjFwNv5s14sdhD@corigine.com> (raw)
In-Reply-To: <e9bafd799489215710f7880214b58d6487407248.1654320767.git.christophe.jaillet@wanadoo.fr>
On Sat, Jun 04, 2022 at 07:33:00AM +0200, Christophe JAILLET wrote:
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
>
> Remove kernel.h when it is not needed.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Thanks for improving the NFP driver.
I think the contents of this patch looks good.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
I also think this patch is appropriate for net-next
("[PATCH net-next] ..." in subject) and should thus be re-submitted
once net-next re-opens for the v5.20 development cycle, which I would
expect to happen in the coming days, after v5.19-rc1 has been released.
I'm happy to handle re-submitting it if you prefer.
next prev parent reply other threads:[~2022-06-04 9:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-04 5:33 [PATCH] nfp: Remove kernel.h when not needed Christophe JAILLET
2022-06-04 9:17 ` Simon Horman [this message]
2022-06-04 12:58 ` Christophe JAILLET
2022-06-06 7:07 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpsjFwNv5s14sdhD@corigine.com \
--to=simon.horman@corigine.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).