netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Petr Vorel <pvorel@suse.cz>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	David Ahern <dsahern@gmail.com>, Sasha Levin <sashal@kernel.org>
Subject: Re: [RFC] Backporting "add second dif to raw, inet{6,}, udp, multicast sockets" to LTS 4.9
Date: Sat, 4 Jun 2022 12:08:02 +0200	[thread overview]
Message-ID: <YpsvAludRUxuK22U@kroah.com> (raw)
In-Reply-To: <YppqNtTmqjeR5cZV@pevik>

On Fri, Jun 03, 2022 at 10:08:22PM +0200, Petr Vorel wrote:
> Hi all,
> 
> David (both), would it be possible to backport your commits from merge
> 9bcb5a572fd6 ("Merge branch 'net-l3mdev-Support-for-sockets-bound-to-enslaved-device'")
> from v4.14-rc1 to LTS 4.9?
> 
> These commits added second dif to raw, inet{6,}, udp, multicast sockets.
> The change is not a fix but a feature - significant change, therefore I
> understand if you're aginast backporting it.
> 
> My motivation is to get backported to LTS 4.9 these fixes from v5.17 (which
> has been backported to all newer stable/LTS trees):
> 2afc3b5a31f9 ("ping: fix the sk_bound_dev_if match in ping_lookup")
> 35a79e64de29 ("ping: fix the dif and sdif check in ping_lookup")
> cd33bdcbead8 ("ping: remove pr_err from ping_lookup")
> 
> which fix small issue with IPv6 in ICMP datagram socket ("ping" socket).
> 
> These 3 commits depend on 9bcb5a572fd6, particularly on:
> 3fa6f616a7a4d ("net: ipv4: add second dif to inet socket lookups")
> 4297a0ef08572 ("net: ipv6: add second dif to inet6 socket lookups")

Can't the fixes be backported without the larger api changes needed?

If not, how many commits are you trying to backport here?  And there's
no need for David to do this work if you need/want these fixes merged.

thanks,

greg k-h

  reply	other threads:[~2022-06-04 10:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03 20:08 [RFC] Backporting "add second dif to raw, inet{6,}, udp, multicast sockets" to LTS 4.9 Petr Vorel
2022-06-04 10:08 ` Greg Kroah-Hartman [this message]
2022-06-04 16:55   ` David Ahern
2022-06-04 17:27     ` Greg Kroah-Hartman
2022-06-06  6:10       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YpsvAludRUxuK22U@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pvorel@suse.cz \
    --cc=sashal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).