From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, ilias.apalodimas@linaro.org,
hawk@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, corbet@lwn.net, linux-doc@vger.kernel.org,
jbrouer@redhat.com, lorenzo.bianconi@redhat.com
Subject: Re: [PATCH v2 net-next] Documentation: update networking/page_pool.rst with ethtool APIs
Date: Wed, 8 Jun 2022 16:20:59 +0200 [thread overview]
Message-ID: <YqCwS540gMwD7T3f@lore-desk> (raw)
In-Reply-To: <20220607210021.05263978@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 721 bytes --]
> On Mon, 6 Jun 2022 22:15:45 +0200 Lorenzo Bianconi wrote:
> > Update page_pool documentation with page_pool ethtool stats APIs.
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> > Changes since v1:
> > - get rid of literal markup
>
> This is not what Andrew and I meant, I don't think. The suggestion was
> to put the information in kdoc of the function, in the source code, and
> then render the kdoc here by adding something like:
>
> .. kernel-doc:: whatever/the/source/is.c
> :identifiers: page_pool_ethtool_stats_get_strings page_pool_ethtool_stats_get_count page_pool_ethtool_stats_get
>
ack, I misunderstood Jonathan's comments. I will fix it.
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-06-08 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 20:15 [PATCH v2 net-next] Documentation: update networking/page_pool.rst with ethtool APIs Lorenzo Bianconi
2022-06-08 4:00 ` Jakub Kicinski
2022-06-08 14:20 ` Lorenzo Bianconi [this message]
2022-07-03 22:47 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqCwS540gMwD7T3f@lore-desk \
--to=lorenzo@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jbrouer@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).