From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 3/3] net: phy: dp83td510: disable cable test support for 1Vpp PHYs
Date: Sat, 11 Jun 2022 17:16:06 +0200 [thread overview]
Message-ID: <YqSxtvZUEmaxmihV@lunn.ch> (raw)
In-Reply-To: <20220608123236.792405-4-o.rempel@pengutronix.de>
> static int dp83td510_cable_test_start(struct phy_device *phydev)
> {
> - int ret;
> + struct dp83td510_priv *priv = phydev->priv;
> + int ret, cfg = 0;
> +
> + /* Generate 2.4Vpp pulse if HW is allowed to do so */
> + if (priv->allow_v2_4_mode) {
> + cfg |= DP83TD510E_TDR_TX_TYPE;
> + } else {
> + /* This PHY do not provide usable results with 1Vpp pulse.
s/do/does
> + * Potentially different dp83td510_tdr_init() values are
> + * needed.
> + */
> + return -EOPNOTSUPP;
> + }
I don't remember the details for v2.4. Is it possible to change up
from 1v to 2.4v for the duration of the cable test? Is there a danger
to damage the link peer? I guess not, since you need to pass EMC
testing which zaps it with 100Kv or something. So is this more a local
supply issue?
Andrew
next prev parent reply other threads:[~2022-06-11 15:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 12:32 [PATCH net-next v3 0/3] net: phy: dp83td510: add cable diag support Oleksij Rempel
2022-06-08 12:32 ` [PATCH net-next v3 1/3] net: phy: dp83td510: add SQI support Oleksij Rempel
2022-06-11 15:08 ` Andrew Lunn
2022-06-08 12:32 ` [PATCH net-next v3 2/3] net: phy: dp83td510: add cable testing support Oleksij Rempel
2022-06-11 15:12 ` Andrew Lunn
2022-06-08 12:32 ` [PATCH net-next v3 3/3] net: phy: dp83td510: disable cable test support for 1Vpp PHYs Oleksij Rempel
2022-06-11 15:16 ` Andrew Lunn [this message]
2022-06-11 15:23 ` Marc Kleine-Budde
2022-06-08 14:28 ` [PATCH net-next v3 0/3] net: phy: dp83td510: add cable diag support Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqSxtvZUEmaxmihV@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).