Re: [PATCH] amd-xgbe: Use platform_irq_count()

[Jean-Philippe Brucker <jean-philippe@linaro.org>]

On Mon, Jun 13, 2022 at 11:39:48AM -0500, Tom Lendacky wrote:
> On 6/9/22 11:14, Jean-Philippe Brucker wrote:
> > The AMD XGbE driver currently counts the number of interrupts assigned
> > to the device by inspecting the pdev->resource array. Since commit
> > a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource from DT
> > core") removed IRQs from this array, the driver now attempts to get all
> > interrupts from 1 to -1U and gives up probing once it reaches an invalid
> > interrupt index.
> > 
> > Obtain the number of IRQs with platform_irq_count() instead.
> > 
> > Fixes: a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource from DT core")
> > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> 
> Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> 
> It looks like the CCP driver does a similar loop looking for IRQ resources
> (sp_get_irqs() in drivers/crypto/ccp/sp-platform.c), have you looked at
> fixing that driver, too? I can submit a patch if you hadn't planned on it.

Ah no, I did very briefly look for similar issues but missed it, feel free
to send the patch

Thanks,
Jean