Re: [PATCH ethtool] sff-8079/8472: Fix missing sff-8472 output in netlink path

[Ido Schimmel <idosch@nvidia.com>]

On Thu, Jun 16, 2022 at 05:50:09PM +0200, Ivan Vecera wrote:
> Commit 5b64c66f58d ("ethtool: Add netlink handler for
> getmodule\r (-m)") provided a netlink variant for getmodule
> but also introduced a regression as netlink output is different
> from ioctl output that provides information from A2h page
> via sff8472_show_all().
> 
> To fix this the netlink path should check a presence of A2h page
> by value of bit 6 in byte 92 of page A0h and if it is set then
> get A2h page and call sff8472_show_all().
> 
> Fixes: 5b64c66f58d ("ethtool: Add netlink handler for getmodule\r (-m)")
> Tested-by: Daniel Juarez <djuarezg@cern.ch>
> Co-authored-by: Ido Schimmel <idosch@nvidia.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>

With Michal's comment:

Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>

Tested with both netlink and ioctl, but only with SFP modules that lack
diagnostic information, as I don't have these at hand.

Michal, note that for ethtool-next we plan to get rid of sfpdiag.c and
fold it into sfpid.c, so that the latter will be able to handle both
SFF-8079 and SFF-8472 using the same memory map. We felt that it's too
big of a change for the main branch.