public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Networking <netdev@vger.kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Andrii Nakryiko <andrii@kernel.org>
Subject: Re: [PATCH net] selftests/net: fix section name when using xdp_dummy.o
Date: Fri, 1 Jul 2022 09:43:45 +0800	[thread overview]
Message-ID: <Yr5RUQYQCB6sgoIo@Laptop-X1> (raw)
In-Reply-To: <CAEf4BzZ-gn9VmMKx8m2kEvTc--DC8Z_hvKXaw_7Q2BY-J7JQQw@mail.gmail.com>

On Thu, Jun 30, 2022 at 12:08:11PM -0700, Andrii Nakryiko wrote:
> On Wed, Jun 29, 2022 at 11:22 PM Hangbin Liu <liuhangbin@gmail.com> wrote:
> >
> > Since commit 8fffa0e3451a ("selftests/bpf: Normalize XDP section names in
> > selftests") the xdp_dummy.o's section name has changed to xdp. But some
> > tests are still using "section xdp_dummy", which make the tests failed.
> > Fix them by updating to the new section name.
> >
> > Fixes: 8fffa0e3451a ("selftests/bpf: Normalize XDP section names in selftests")
> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> > ---
> 
> Thanks for fixing this! BTW, does iproute2 support selecting programs
> by its name (not section name)? Only the program name is unique, there
> could be multiple programs with the same SEC("xdp").

Good point. iproute2 do not support selecting programs by its name yet.
I will working on it to add this support.

Thanks
Hangbin

  reply	other threads:[~2022-07-01  1:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-30  6:22 [PATCH net] selftests/net: fix section name when using xdp_dummy.o Hangbin Liu
2022-06-30 19:08 ` Andrii Nakryiko
2022-07-01  1:43   ` Hangbin Liu [this message]
2022-07-02  3:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yr5RUQYQCB6sgoIo@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox