From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A303ECCA47E for ; Mon, 20 Jun 2022 17:44:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243321AbiFTRoQ (ORCPT ); Mon, 20 Jun 2022 13:44:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232587AbiFTRoP (ORCPT ); Mon, 20 Jun 2022 13:44:15 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8760E19C03; Mon, 20 Jun 2022 10:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655747053; x=1687283053; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=49F6Qlkni1HEmNtcuftY0iBgdLMBs7pfcE3RK6wafsg=; b=F4hedf3olm7Xw9ntHevYspZCIdNmaMIHFeS8VN14hZCu9LLyDjjAoa41 hqqFs0NbLBXISb9C/LssLZwtLEp81+aoOIUD5NA6XmsgE7sc9I4AirFsw srMo3BwYNhPICZGe6ARvfgWXe8F8hyFFF4Ld+5yAgPQFpQPCQPJBfQr71 nLwty5aMLFyCrzxpfM4NEystDRSHZATgvlcS3FdIwcKRl85VdJBD5M2Ok bSVLnoUM0bfsVTiR6WKGFnYWGZGfcv/7BdJWJKyI2Xf6zIPjZUZQa8azv T4gf+EDzj3lWr6zzsq7q0lmE3wGGx+g/+wu/vOdW/x7S7tYL+zzv4ihyL Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10384"; a="278719449" X-IronPort-AV: E=Sophos;i="5.92,207,1650956400"; d="scan'208";a="278719449" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2022 10:44:13 -0700 X-IronPort-AV: E=Sophos;i="5.92,207,1650956400"; d="scan'208";a="654778352" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2022 10:44:08 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1o3LRV-000kZs-Hv; Mon, 20 Jun 2022 20:44:05 +0300 Date: Mon, 20 Jun 2022 20:44:05 +0300 From: Andy Shevchenko To: Marcin Wojtas Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, rafael@kernel.org, lenb@kernel.org, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk, hkallweit1@gmail.com, gjb@semihalf.com, jaz@semihalf.com, tn@semihalf.com, Samer.El-Haj-Mahmoud@arm.com, upstream@semihalf.com Subject: Re: [net-next: PATCH 04/12] net: mvpp2: initialize port fwnode pointer Message-ID: References: <20220620150225.1307946-1-mw@semihalf.com> <20220620150225.1307946-5-mw@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 20, 2022 at 08:43:05PM +0300, Andy Shevchenko wrote: > On Mon, Jun 20, 2022 at 05:02:17PM +0200, Marcin Wojtas wrote: > > As a preparation to switch the DSA subsystem from using > > of_find_net_device_by_node() to its more generic fwnode_ > > equivalent, the port's device structure should be updated > > with its fwnode pointer, similarly to of_node - see analogous > > commit c4053ef32208 ("net: mvpp2: initialize port of_node pointer"). > > > > This patch is required to prevent a regression before updating > > the DSA API on boards that connect the mvpp2 port to switch, > > such as Clearfog GT-8K or CN913x CEx7 Evaluation Board. > > ... > > > dev->dev.of_node = port_node; > > + dev->dev.fwnode = port_fwnode; > > device_set_node() ? Ah, important remark to all device_set_node() comments. It assumes that you replace _both_ assignments with _single_ call. -- With Best Regards, Andy Shevchenko