From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jakub Kicinski <kuba@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
davem@davemloft.net, kbuild-all@lists.01.org,
netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew@lunn.ch, hkallweit1@gmail.com, boon.leong.ong@intel.com
Subject: Re: [PATCH net-next] net: pcs: xpcs: select PHYLINK in Kconfig
Date: Tue, 21 Jun 2022 08:08:29 +0100 [thread overview]
Message-ID: <YrFubYKuqPbT4fRc@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220620174800.6dc60a5b@kernel.org>
On Mon, Jun 20, 2022 at 05:48:00PM -0700, Jakub Kicinski wrote:
> On Tue, 21 Jun 2022 05:49:57 +0800 kernel test robot wrote:
> > I love your patch! Yet something to improve:
> >
> > [auto build test ERROR on net-next/master]
> >
> > url: https://github.com/intel-lab-lkp/linux/commits/Jakub-Kicinski/net-pcs-xpcs-select-PHYLINK-in-Kconfig/20220621-042123
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git dbca1596bbb08318f5e3b3b99f8ca0a0d3830a65
> > config: i386-tinyconfig
> > compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
> > reproduce (this is a W=1 build):
> > # https://github.com/intel-lab-lkp/linux/commit/a3120516f7ee66896bb0d3c90fe653ce0cb3a09f
> > git remote add linux-review https://github.com/intel-lab-lkp/linux
> > git fetch --no-tags linux-review Jakub-Kicinski/net-pcs-xpcs-select-PHYLINK-in-Kconfig/20220621-042123
> > git checkout a3120516f7ee66896bb0d3c90fe653ce0cb3a09f
> > make W=1 ARCH=i386 tinyconfig
> > make W=1 ARCH=i386
> >
> > If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> > >> drivers/net/phy/Kconfig:16:error: recursive dependency detected!
> > drivers/net/phy/Kconfig:16: symbol PHYLIB is selected by PHYLINK
> > drivers/net/phy/Kconfig:6: symbol PHYLINK is selected by PCS_XPCS
> > drivers/net/pcs/Kconfig:8: symbol PCS_XPCS depends on MDIO_DEVICE
> > drivers/net/mdio/Kconfig:6: symbol MDIO_DEVICE is selected by PHYLIB
> > For a resolution refer to Documentation/kbuild/kconfig-language.rst
> > subsection "Kconfig recursive dependency limitations"
>
> Dunno what the best practice is in that case :S
> I'll leave this to the experts.
Would it work to make all the PCS drivers depend on PHYLINK ?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-06-21 7:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 20:19 [PATCH net-next] net: pcs: xpcs: select PHYLINK in Kconfig Jakub Kicinski
2022-06-20 21:49 ` kernel test robot
2022-06-21 0:48 ` Jakub Kicinski
2022-06-21 7:08 ` Russell King (Oracle) [this message]
2022-06-20 22:00 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrFubYKuqPbT4fRc@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).