From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Ong Boon Leong <boon.leong.ong@intel.com>
Subject: Re: [PATCH net-next v2] net: pcs: xpcs: select PHYLINK in Kconfig
Date: Wed, 22 Jun 2022 15:35:05 +0100 [thread overview]
Message-ID: <YrMomUJ9HO0aIukP@shell.armlinux.org.uk> (raw)
In-Reply-To: <54288e0ef07ac8a40cf28d782aa3f1e8acaa4b59.1655906864.git.pabeni@redhat.com>
On Wed, Jun 22, 2022 at 04:31:56PM +0200, Paolo Abeni wrote:
> This is another attempt at fixing:
>
> >> ERROR: modpost: "phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined!
> >> ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined!
>
> We can't mix select and depends, or that will trigger a circular dependency.
> We can't use 'depends on' for PHYLINK, as the latter config is not
> user-visible.
> Pull-in all the dependencies via 'select'.
> Note that PHYLINK already selects PHYLIB, which in turn selects MDIO_DEVICE.
>
> v1 -> v2:
> - use 'select' instead of 'depends on' (Jakub)
Why? I'm failing to understand the rationale here. See my reply to
Jakub sent a few minutes ago.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2022-06-22 14:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 14:31 [PATCH net-next v2] net: pcs: xpcs: select PHYLINK in Kconfig Paolo Abeni
2022-06-22 14:35 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrMomUJ9HO0aIukP@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).