* [PATCH net-next] net: lan743x: Use correct variable in lan743x_sgmii_config()
@ 2022-06-23 13:34 Dan Carpenter
2022-06-24 11:10 ` Andrew Lunn
2022-06-24 18:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-06-23 13:34 UTC (permalink / raw)
To: Bryan Whitehead, Raju Lakkaraju
Cc: UNGLinuxDriver, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Andrew Lunn, netdev, kernel-janitors
There is a copy and paste bug in lan743x_sgmii_config() so it checks
if (ret < 0) instead of if (mii_ctl < 0).
Fixes: 46b777ad9a8c ("net: lan743x: Add support to SGMII 1G and 2.5G")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/microchip/lan743x_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
index 79ecf296161e..a9a1dea6d731 100644
--- a/drivers/net/ethernet/microchip/lan743x_main.c
+++ b/drivers/net/ethernet/microchip/lan743x_main.c
@@ -1212,8 +1212,8 @@ static int lan743x_sgmii_config(struct lan743x_adapter *adapter)
/* SGMII/1000/2500BASE-X PCS power down */
mii_ctl = lan743x_sgmii_read(adapter, MDIO_MMD_VEND2, MII_BMCR);
- if (ret < 0)
- return ret;
+ if (mii_ctl < 0)
+ return mii_ctl;
mii_ctl |= BMCR_PDOWN;
ret = lan743x_sgmii_write(adapter, MDIO_MMD_VEND2, MII_BMCR, mii_ctl);
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: lan743x: Use correct variable in lan743x_sgmii_config()
2022-06-23 13:34 [PATCH net-next] net: lan743x: Use correct variable in lan743x_sgmii_config() Dan Carpenter
@ 2022-06-24 11:10 ` Andrew Lunn
2022-06-24 18:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2022-06-24 11:10 UTC (permalink / raw)
To: Dan Carpenter
Cc: Bryan Whitehead, Raju Lakkaraju, UNGLinuxDriver, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev,
kernel-janitors
On Thu, Jun 23, 2022 at 04:34:03PM +0300, Dan Carpenter wrote:
> There is a copy and paste bug in lan743x_sgmii_config() so it checks
> if (ret < 0) instead of if (mii_ctl < 0).
>
> Fixes: 46b777ad9a8c ("net: lan743x: Add support to SGMII 1G and 2.5G")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: lan743x: Use correct variable in lan743x_sgmii_config()
2022-06-23 13:34 [PATCH net-next] net: lan743x: Use correct variable in lan743x_sgmii_config() Dan Carpenter
2022-06-24 11:10 ` Andrew Lunn
@ 2022-06-24 18:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-06-24 18:30 UTC (permalink / raw)
To: Dan Carpenter
Cc: bryan.whitehead, Raju.Lakkaraju, UNGLinuxDriver, davem, edumazet,
kuba, pabeni, andrew, netdev, kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 23 Jun 2022 16:34:03 +0300 you wrote:
> There is a copy and paste bug in lan743x_sgmii_config() so it checks
> if (ret < 0) instead of if (mii_ctl < 0).
>
> Fixes: 46b777ad9a8c ("net: lan743x: Add support to SGMII 1G and 2.5G")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/ethernet/microchip/lan743x_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Here is the summary with links:
- [net-next] net: lan743x: Use correct variable in lan743x_sgmii_config()
https://git.kernel.org/netdev/net-next/c/b4cbd7a9339f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-24 18:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-23 13:34 [PATCH net-next] net: lan743x: Use correct variable in lan743x_sgmii_config() Dan Carpenter
2022-06-24 11:10 ` Andrew Lunn
2022-06-24 18:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).