From: Andrew Lunn <andrew@lunn.ch>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Sebastian Reichel <sebastian.reichel@collabora.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
David Wu <david.wu@rock-chips.com>,
kernel@collabora.com
Subject: Re: [PATCH 1/3] net: ethernet: stmmac: dwmac-rk: Disable delayline if it is invalid
Date: Sat, 25 Jun 2022 08:50:57 +0200 [thread overview]
Message-ID: <YrawUa4VcRrMvNJf@lunn.ch> (raw)
In-Reply-To: <CAMdYzYr_EA2Oxf6Q-WkX987eWUKRokRR1EsCWM4J+BcF+OkO9A@mail.gmail.com>
> The driver already sets the delays to 0 in case of the rgmii-id modes.
> 0 is disabled, even in this patch. The only thing this patch does is
> change the behavior when the delays are not set. If the rx delays
> should be 0, they should be defined as 0 in the device tree. There is
> rgmii-rxid for a reason as well, but if they are setting the rx delay
> to 0 with rgmii that implies this hardware is fundamentally broken.
Or the delay is implemented by longer tracks on the PCB. It happens
sometimes, but not very often.
Andrew
next prev parent reply other threads:[~2022-06-25 6:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 16:28 [PATCH 0/3] RK3588 Ethernet Support Sebastian Reichel
2022-06-23 16:28 ` [PATCH 1/3] net: ethernet: stmmac: dwmac-rk: Disable delayline if it is invalid Sebastian Reichel
2022-06-24 11:18 ` Andrew Lunn
2022-06-24 16:29 ` Sebastian Reichel
2022-06-24 16:52 ` Andrew Lunn
2022-06-24 17:35 ` Sebastian Reichel
2022-06-24 17:37 ` Andrew Lunn
2022-06-24 20:15 ` Sebastian Reichel
2022-06-24 23:43 ` Peter Geis
2022-06-25 6:50 ` Andrew Lunn [this message]
2022-06-23 16:28 ` [PATCH 2/3] net: ethernet: stmmac: dwmac-rk: Add gmac support for rk3588 Sebastian Reichel
2022-06-23 16:28 ` [PATCH 3/3] dt-bindings: net: rockchip-dwmac: add rk3588 gmac compatible Sebastian Reichel
2022-06-26 20:18 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrawUa4VcRrMvNJf@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).