From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83FF9C433EF for ; Sun, 26 Jun 2022 16:54:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231365AbiFZQyY (ORCPT ); Sun, 26 Jun 2022 12:54:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbiFZQyX (ORCPT ); Sun, 26 Jun 2022 12:54:23 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82A25BE14; Sun, 26 Jun 2022 09:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=gB2QPpcGyRRnZk6fs1yYruS4OxObDMfgC2+ULwiDvpQ=; b=YCWQmz2EFDswZnqbPe01rXcltd aniNjahs/z9YYCGOt6jGO+28NuA4gCHVvMMgwS8S9LeqRC6U+jBhvatzZHI/4DP/lkmDExyZHrN9+ w69S0tzOeQ8ksg1j5EK4emh6UopwWdd2cdhVaLkFQUvu+e4Gm30WFr0S+ZPKlVjmXaTw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1o5VWT-008JPD-CS; Sun, 26 Jun 2022 18:54:09 +0200 Date: Sun, 26 Jun 2022 18:54:09 +0200 From: Andrew Lunn To: Oleksij Rempel Cc: Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Lukas Wunner Subject: Re: [PATCH net-next v2 1/1] net: phy: ax88772a: fix lost pause advertisement configuration Message-ID: References: <20220626152703.18157-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220626152703.18157-1-o.rempel@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Jun 26, 2022 at 05:27:03PM +0200, Oleksij Rempel wrote: > In case of asix_ax88772a_link_change_notify() workaround, we run soft > reset which will automatically clear MII_ADVERTISE configuration. The > PHYlib framework do not know about changed configuration state of the > PHY, so we need use phy_init_hw() to reinit PHY configuration. > > Fixes: dde258469257 ("net: usb/phy: asix: add support for ax88772A/C PHYs") > Signed-off-by: Oleksij Rempel Reviewed-by: Andrew Lunn Andrew