From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Divya Koppera <Divya.Koppera@microchip.com>,
hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com,
Madhuri.Sripada@microchip.com
Subject: Re: [PATCH net-next] net: phy: micrel: Adding LED feature for LAN8814 PHY
Date: Wed, 29 Jun 2022 14:44:15 +0100 [thread overview]
Message-ID: <YrxXL/p3q35SsXmk@shell.armlinux.org.uk> (raw)
In-Reply-To: <YrsRUd6GPG0qCJsw@lunn.ch>
On Tue, Jun 28, 2022 at 04:33:53PM +0200, Andrew Lunn wrote:
> On Tue, Jun 28, 2022 at 11:19:25AM +0530, Divya Koppera wrote:
> > LED support for extended mode where
> > LED 1: Enhanced Mode 5 (10M/1000M/Activity)
> > LED 2: Enhanced Mode 4 (100M/1000M/Activity)
> >
> > By default it supports KSZ9031 LED mode
>
> You need to update the binding documentation.
What happened to "use the LEDs interface, don't invent private bindings
for PHY LEDs" ?
Does this mean the private bindings are now acceptable and I can
resubmit my 88x3310 LED support code?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-06-29 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 5:49 [PATCH net-next] net: phy: micrel: Adding LED feature for LAN8814 PHY Divya Koppera
2022-06-28 14:33 ` Andrew Lunn
2022-06-29 13:44 ` Russell King (Oracle) [this message]
2022-06-29 17:01 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrxXL/p3q35SsXmk@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Divya.Koppera@microchip.com \
--cc=Madhuri.Sripada@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).