From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: "Björn Töpel" <bjorn.topel@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Netdev <netdev@vger.kernel.org>,
"Karlsson, Magnus" <magnus.karlsson@intel.com>
Subject: Re: [PATCH bpf] xsk: mark napi_id on sendmsg()
Date: Wed, 29 Jun 2022 16:28:19 +0200 [thread overview]
Message-ID: <Yrxhg2R6rk1PKe4E@boxer> (raw)
In-Reply-To: <CAJ+HfNgBXTWLWOthG1mOmy8ZZyzLAggpZLq9qOzbdzRxxmK77Q@mail.gmail.com>
On Wed, Jun 29, 2022 at 03:39:57PM +0200, Björn Töpel wrote:
> On Wed, 29 Jun 2022 at 14:45, Björn Töpel <bjorn.topel@gmail.com> wrote:
> >
> > TL;DR, I think it's a good addition. One small nit below:
> >
>
> I forgot one thing. Setting napi_id should be gated by
> "CONFIG_NET_RX_BUSY_POLL" ifdefs.
napi id marking functions are wrapped inside with this ifdef
prev parent reply other threads:[~2022-06-29 14:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 10:57 [PATCH bpf] xsk: mark napi_id on sendmsg() Maciej Fijalkowski
2022-06-29 12:45 ` Björn Töpel
2022-06-29 12:53 ` Maciej Fijalkowski
2022-06-29 13:18 ` Magnus Karlsson
2022-06-29 16:16 ` Jakub Kicinski
2022-06-29 16:17 ` Jakub Kicinski
2022-06-30 11:53 ` Maciej Fijalkowski
2022-06-30 15:52 ` Jakub Kicinski
2022-06-29 13:39 ` Björn Töpel
2022-06-29 14:28 ` Maciej Fijalkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yrxhg2R6rk1PKe4E@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox