From: Andrew Lunn <andrew@lunn.ch>
To: Michael Walle <michael@walle.cc>
Cc: Xu Liang <lxu@maxlinear.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/4] net: phy: mxl-gpy: cache PHY firmware version
Date: Tue, 12 Jul 2022 15:24:35 +0200 [thread overview]
Message-ID: <Ys12E0mVdc3rd7it@lunn.ch> (raw)
In-Reply-To: <20220712131554.2737792-3-michael@walle.cc>
> + priv->fw_type = FIELD_GET(PHY_FWV_TYPE_MASK, fw_version);
> + priv->fw_minor = FIELD_GET(PHY_FWV_MINOR_MASK, fw_version);
>
> ret = gpy_hwmon_register(phydev);
> if (ret)
> return ret;
>
> + /* Show GPY PHY FW version in dmesg */
> phydev_info(phydev, "Firmware Version: 0x%04X (%s)\n", fw_version,
> (fw_version & PHY_FWV_REL_MASK) ? "release" : "test");
Maybe use fw_type and fw_minor. It makes the patch a bit bigger, but
makes the code more consistent.
Andrew
next prev parent reply other threads:[~2022-07-12 13:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 13:15 [PATCH net-next 0/4] net: phy: mxl-gpy: version fix and improvements Michael Walle
2022-07-12 13:15 ` [PATCH net-next 1/4] net: phy: mxl-gpy: fix version reporting Michael Walle
2022-07-12 13:19 ` Andrew Lunn
2022-07-12 13:15 ` [PATCH net-next 2/4] net: phy: mxl-gpy: cache PHY firmware version Michael Walle
2022-07-12 13:24 ` Andrew Lunn [this message]
2022-07-12 13:27 ` Michael Walle
2022-07-12 13:31 ` Andrew Lunn
2022-07-12 13:15 ` [PATCH net-next 3/4] net: phy: mxl-gpy: rename the FW type field name Michael Walle
2022-07-12 13:26 ` Andrew Lunn
2022-07-12 13:15 ` [PATCH net-next 4/4] net: phy: mxl-gpy: print firmware in human readable form Michael Walle
2022-07-12 13:27 ` Andrew Lunn
2022-07-13 13:30 ` [PATCH net-next 0/4] net: phy: mxl-gpy: version fix and improvements patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ys12E0mVdc3rd7it@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).