Re: [patch net-next 2/3] net: devlink: call lockdep_assert_held() for devlink->lock directly

Jakub Kicinski
2022-07-01T16:33:23Z

On Fri, 1 Jul 2022 11:59:25 +0200 Jiri Pirko wrote:
> In devlink.c there is direct access to whole struct devlink so there is
> no need to use helper. So obey the customs and work with lock directly
> avoiding helpers which might obfuscate things a bit.

> diff --git a/net/core/devlink.c b/net/core/devlink.c
> index 25b481dd1709..a7477addbd59 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -10185,7 +10185,7 @@ int devl_rate_leaf_create(struct devlink_port *devlink_port, void *priv)
> struct devlink *devlink = devlink_port->devlink;
> struct devlink_rate *devlink_rate;
>
> - devl_assert_locked(devlink_port->devlink);
> + lockdep_assert_held(&devlink_port->devlink->lock);

I don't understand why. Do we use lockdep asserts directly on rtnl_mutex
in rtnetlink.c?