From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Hugues ANGUELKOV <hanguelkov@randorisec.fr>
Cc: netdev@vger.kernel.org, security@kernel.org,
kadlec@netfilter.org, fw@strlen.de, davy <davy@randorisec.fr>,
amongodin@randorisec.fr, kuba@kernel.org,
torvalds@linuxfoundation.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v1] netfilter: nf_tables: fix nft_set_elem_init heap buffer overflow
Date: Sat, 2 Jul 2022 21:11:56 +0200 [thread overview]
Message-ID: <YsCYfBSobCXxy7Ok@salvia> (raw)
In-Reply-To: <YsCVB2Jh8d6mM6f7@salvia>
On Sat, Jul 02, 2022 at 08:57:14PM +0200, Pablo Neira Ayuso wrote:
> On Sat, Jul 02, 2022 at 07:59:11PM +0200, Hugues ANGUELKOV wrote:
> > From d91007a18140e02a1f12c9627058a019fe55b8e6 Mon Sep 17 00:00:00 2001
> > From: Arthur Mongodin <amongodin@randorisec.fr>
> > Date: Sat, 2 Jul 2022 17:11:48 +0200
> > Subject: [PATCH v1] netfilter: nf_tables: fix nft_set_elem_init heap buffer
> > overflow
> >
> > The length used for the memcpy in nft_set_elem_init may exceed the bound
> > of the allocated object due to a weak check in nft_setelem_parse_data.
> > As a user can add an element with a data type NFT_DATA_VERDICT to a set
> > with a data type different of NFT_DATA_VERDICT, then the comparison on the
> > data type of the element allows to avoid the comparaison on the data length
> > This fix forces the length comparison in nft_setelem_parse_data by removing
> > the check for NFT_DATA_VERDICT type.
>
> https://patchwork.ozlabs.org/project/netfilter-devel/patch/20220702021631.796822-1-pablo@netfilter.org/
For the record, pull request is already available with pending fixes
for net.
https://patchwork.ozlabs.org/project/netfilter-devel/patch/20220702191029.238563-1-pablo@netfilter.org/
https://patchwork.ozlabs.org/project/netfilter-devel/patch/20220702191029.238563-2-pablo@netfilter.org/
https://patchwork.ozlabs.org/project/netfilter-devel/patch/20220702191029.238563-3-pablo@netfilter.org/
next prev parent reply other threads:[~2022-07-02 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-02 17:59 [PATCH v1] netfilter: nf_tables: fix nft_set_elem_init heap buffer overflow Hugues ANGUELKOV
2022-07-02 18:57 ` Pablo Neira Ayuso
2022-07-02 19:11 ` Pablo Neira Ayuso [this message]
2022-07-02 19:23 ` Hugues ANGUELKOV
2022-07-02 18:59 ` Jakub Kicinski
2022-07-02 19:02 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsCYfBSobCXxy7Ok@salvia \
--to=pablo@netfilter.org \
--cc=amongodin@randorisec.fr \
--cc=davy@randorisec.fr \
--cc=fw@strlen.de \
--cc=hanguelkov@randorisec.fr \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=security@kernel.org \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).