From: Ido Schimmel <idosch@nvidia.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>, Petr Machata <petrm@nvidia.com>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net 1/3] selftests: forwarding: fix flood_unicast_test when h2 supports IFF_UNICAST_FLT
Date: Sun, 3 Jul 2022 13:02:36 +0300 [thread overview]
Message-ID: <YsFpPKyeUt26UPw4@shredder> (raw)
In-Reply-To: <20220703073626.937785-2-vladimir.oltean@nxp.com>
On Sun, Jul 03, 2022 at 10:36:24AM +0300, Vladimir Oltean wrote:
> As mentioned in the blamed commit, flood_unicast_test() works by
> checking the match count on a tc filter placed on the receiving
> interface.
>
> But the second host interface (host2_if) has no interest in receiving a
> packet with MAC DA de:ad:be:ef:13:37, so its RX filter drops it even
> before the ingress tc filter gets to be executed. So we will incorrectly
> get the message "Packet was not flooded when should", when in fact, the
> packet was flooded as expected but dropped due to an unrelated reason,
> at some other layer on the receiving side.
>
> Force h2 to accept this packet by temporarily placing it in promiscuous
> mode. Alternatively we could either deliver to its MAC address or use
> tcpdump_start, but this has the fewest complications.
>
> This fixes the "flooding" test from bridge_vlan_aware.sh and
> bridge_vlan_unaware.sh, which calls flood_test from the lib.
>
> Fixes: 236dd50bf67a ("selftests: forwarding: Add a test for flooded traffic")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2022-07-03 10:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-03 7:36 [PATCH net 0/3] Fix bridge_vlan_aware.sh and bridge_vlan_unaware.sh with IFF_UNICAST_FLT Vladimir Oltean
2022-07-03 7:36 ` [PATCH net 1/3] selftests: forwarding: fix flood_unicast_test when h2 supports IFF_UNICAST_FLT Vladimir Oltean
2022-07-03 10:02 ` Ido Schimmel [this message]
2022-07-03 7:36 ` [PATCH net 2/3] selftests: forwarding: fix learning_test when h1 " Vladimir Oltean
2022-07-03 10:03 ` Ido Schimmel
2022-07-03 7:36 ` [PATCH net 3/3] selftests: forwarding: fix error message in learning_test Vladimir Oltean
2022-07-03 10:03 ` Ido Schimmel
2022-07-05 10:00 ` [PATCH net 0/3] Fix bridge_vlan_aware.sh and bridge_vlan_unaware.sh with IFF_UNICAST_FLT patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsFpPKyeUt26UPw4@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).