From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F66EC433EF for ; Mon, 4 Jul 2022 17:18:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234282AbiGDRSC (ORCPT ); Mon, 4 Jul 2022 13:18:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233373AbiGDRR6 (ORCPT ); Mon, 4 Jul 2022 13:17:58 -0400 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 461CB120BD for ; Mon, 4 Jul 2022 10:17:56 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9A50B5C00B2; Mon, 4 Jul 2022 13:17:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 04 Jul 2022 13:17:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1656955074; x= 1657041474; bh=Dg+SE6V77FnOoUivR2AGYvk6gRYLfawEFeKRY/bNZf4=; b=c fNh0E5Y/GRPKkmtFDMlEirGDYhjZVd2dBKTCaSuFa9qLn5pSCuRKdUGWYfx5wCvd GKvM2O/fODt9rKbupG7QaT/DF83UimGcWuxu8yZIAxcR0mxs/sBiKOZRv27qlpCt i5rM1NdM+F8JfJ+xbYGfX7wIy+XlIGN669u7ipVkdnZ5Li+Fx5Nii+qDNAfbUmBb 2iO6n1Esz0LjB0+O9jT92cLqJMtr133JNb1E9caQbguCpA++XEsuCpXcFkmpkc81 MV1QUKyEmBDlRRfWV6J4qFq7j+jbkzxHkm51JzDCFg65SPaSHbgasdb5tEmrMek6 jP0I/TQcwVTtfqktdLmjg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehledgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtugfgjgesthekredttddtjeenucfhrhhomhepkfgu ohcuufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrf grthhtvghrnhepudeiiedvveekuedvgfehieehueevjefgleeggeejgeekgfdvuedtueek jeekffetnecuffhomhgrihhnpehsphhinhhitghsrdhnvghtnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihguohhstghhsehiughoshgthhdr ohhrgh X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 4 Jul 2022 13:17:53 -0400 (EDT) Date: Mon, 4 Jul 2022 20:17:51 +0300 From: Ido Schimmel To: Jamal Hadi Salim Cc: Petr Machata , David Ahern , Stephen Hemminger , Linux Kernel Network Developers Subject: Re: Report: iproute2 build broken? Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jul 04, 2022 at 12:59:45PM -0400, Jamal Hadi Salim wrote: > Thanks Ido. That fixed it. > General question: do we need a "stable" iproute2? Maybe a new point release is enough (e.g., 5.18.1)? I see that's what Stephen did the last time something similar happened: $ git log v4.14.0^..v4.14.1 commit 212b52299e90a369373b9e38924b9492df695559 Author: Stephen Hemminger Date: Mon Nov 13 10:09:57 2017 -0800 v4.14.1 commit b867d46dafee4ac81acecd2d398c392eb43b50bb Author: Stephen Hemminger Date: Mon Nov 13 10:08:39 2017 -0800 utils: remove duplicate include of ctype.h Signed-off-by: Stephen Hemminger commit aba736dc251ee7aa7c2035e18bffc37b18f05222 Author: Leon Romanovsky Date: Mon Nov 13 12:21:19 2017 +0200 ip: Fix compilation break on old systems As was reported [1], the iproute2 fails to compile on old systems, in Cong's case, it was Fedora 19, in our case it was RedHat 7.2, which failed with the following errors during compilation: ipxfrm.c: In function ‘xfrm_selector_print’: ipxfrm.c:479:7: error: ‘IPPROTO_MH’ undeclared (first use in this function) case IPPROTO_MH: ^ ipxfrm.c:479:7: note: each undeclared identifier is reported only once for each function it appears in ipxfrm.c: In function ‘xfrm_selector_upspec_parse’: ipxfrm.c:1345:8: error: ‘IPPROTO_MH’ undeclared (first use in this function) case IPPROTO_MH: ^ make[1]: *** [ipxfrm.o] Error 1 The reason to it is the order of headers files. The IPPROTO_MH field is set in kernel's UAPI header file (in6.h), but only in case __UAPI_DEF_IPPROTO_V6 is set before. That define comes from other kernel's header file (libc-compat.h) and is set in case there are no previous libc relevant declarations. In ip code, the include of causes to indirect inclusion of and it sets __UAPI_DEF_IPPROTO_V6 to be zero and prevents from IPPROTO_MH declaration. This patch takes the simplest possible approach to fix the compilation error by checking if IPPROTO_MH was defined before and in case it wasn't, it defines it to be the same as in the kernel. [1] https://www.spinics.net/lists/netdev/msg463980.html Cc: Cong Wang Cc: Riad Abo Raed Signed-off-by: Leon Romanovsky commit 7d14d00795c334a288f1733bfdabdf363a7f962c Author: Stephen Hemminger Date: Sun Nov 12 16:29:43 2017 -0800 v4.14.0