From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com, mlxsw@nvidia.com, saeedm@nvidia.com,
moshe@nvidia.com
Subject: Re: [patch net-next 2/3] net: devlink: call lockdep_assert_held() for devlink->lock directly
Date: Thu, 7 Jul 2022 10:04:32 +0200 [thread overview]
Message-ID: <YsaTkAV9uavlvPBH@nanopsycho> (raw)
In-Reply-To: <20220704195839.34128dd3@kernel.org>
Tue, Jul 05, 2022 at 04:58:39AM CEST, kuba@kernel.org wrote:
>On Mon, 4 Jul 2022 08:19:17 +0200 Jiri Pirko wrote:
>> Jakub, I don't really care. If you say we should do it differently, I
>> will do it differently. I just want the use to be consistent. From the
>> earlier reactions of DaveM on such helpers, I got an impression we don't
>> want them if possible. If this is no longer true, I'm fine with it. Just
>> tell me what I should do.
>
>As I said - my understanding is that we want to discourage (driver)
>authors from wrapping locks in lock/unlock helpers. Which was very
>fashionable at some point (IDK why, but it seem to have mostly gone
>away?).
>
>If the helper already exists I think consistency wins and we should use
>it.
Okay, will send a patch to convert devlink.c to use these helpers.
Thanks!
next prev parent reply other threads:[~2022-07-07 8:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 9:59 [patch net-next 0/3] net: devlink: devl_* cosmetic fixes Jiri Pirko
2022-07-01 9:59 ` [patch net-next 1/3] net: devlink: move unlocked function prototypes alongside the locked ones Jiri Pirko
2022-07-01 9:59 ` [patch net-next 2/3] net: devlink: call lockdep_assert_held() for devlink->lock directly Jiri Pirko
2022-07-01 16:33 ` Jakub Kicinski
2022-07-02 15:58 ` Jiri Pirko
2022-07-02 19:29 ` Jakub Kicinski
2022-07-04 6:19 ` Jiri Pirko
2022-07-05 2:58 ` Jakub Kicinski
2022-07-07 8:04 ` Jiri Pirko [this message]
2022-07-01 9:59 ` [patch net-next 3/3] net: devlink: fix unlocked vs locked functions descriptions Jiri Pirko
2022-07-01 16:30 ` Jakub Kicinski
2022-07-01 16:35 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsaTkAV9uavlvPBH@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).