From: Andrew Lunn <andrew@lunn.ch>
To: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Cc: michal.simek@xilinx.com, nicolas.ferre@microchip.com,
claudiu.beznea@microchip.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
gregkh@linuxfoundation.org, ronak.jain@xilinx.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
git@xilinx.com, git@amd.com
Subject: Re: [PATCH net-next 2/2] net: macb: Add zynqmp SGMII dynamic configuration support
Date: Sun, 24 Jul 2022 18:53:59 +0200 [thread overview]
Message-ID: <Yt15J6fO5j9jxFxp@lunn.ch> (raw)
In-Reply-To: <1658477520-13551-3-git-send-email-radhey.shyam.pandey@amd.com>
> + ret = of_property_read_u32_array(pdev->dev.of_node, "power-domains",
> + pm_info, ARRAY_SIZE(pm_info));
> + if (ret < 0) {
> + dev_err(&pdev->dev, "Failed to read power management information\n");
> + return ret;
> + }
> + ret = zynqmp_pm_set_gem_config(pm_info[1], GEM_CONFIG_FIXED, 0);
> + if (ret < 0)
> + return ret;
> +
Documentation/devicetree/bindings/net/cdns,macb.yaml says:
power-domains:
maxItems: 1
Yet you are using pm_info[1]?
Andrew
next prev parent reply other threads:[~2022-07-24 16:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 8:11 [PATCH net-next 0/2] macb: add zynqmp SGMII dynamic configuration support Radhey Shyam Pandey
2022-07-22 8:11 ` [PATCH net-next 1/2] firmware: xilinx: add support for sd/gem config Radhey Shyam Pandey
2022-07-22 8:52 ` Claudiu.Beznea
2022-07-25 13:00 ` Pandey, Radhey Shyam
2022-07-22 8:12 ` [PATCH net-next 2/2] net: macb: Add zynqmp SGMII dynamic configuration support Radhey Shyam Pandey
2022-07-22 8:52 ` Claudiu.Beznea
2022-07-25 13:26 ` Pandey, Radhey Shyam
2022-07-22 9:24 ` Conor.Dooley
2022-07-24 16:53 ` Andrew Lunn [this message]
2022-07-25 14:34 ` Pandey, Radhey Shyam
2022-07-25 17:11 ` Andrew Lunn
2022-07-26 18:48 ` Pandey, Radhey Shyam
2022-07-29 12:16 ` Pandey, Radhey Shyam
2022-07-29 13:08 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yt15J6fO5j9jxFxp@lunn.ch \
--to=andrew@lunn.ch \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=ronak.jain@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).