From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D231C433EF for ; Fri, 15 Jul 2022 20:33:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229691AbiGOUdz (ORCPT ); Fri, 15 Jul 2022 16:33:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229586AbiGOUdy (ORCPT ); Fri, 15 Jul 2022 16:33:54 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DB9E13DE8; Fri, 15 Jul 2022 13:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657917233; x=1689453233; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=XzNWkK32OdUPfify8t3CgVvtAtYBTKOWpWWoVHFF5eE=; b=JQuQJZizkP0iJDcKb5nrp55++1ttE6Uudc0CUKosgbDFsJ9QoqEAaOFE TS/nQTap4SHli4zLv/Ix+HYIDGTQjN/u0xwliR1KbPLcwPdbf4iTmVG/z HjGQqAkXONP47IeA0O9yREliepHVBYDXP3YrmSD/CSwNXbRZaaqVY91el peUZ/ZEu3nZ6BYC0L5wTHxr5BIH6Whehf8hEyKUAbD2jttULqeUHQ1uat hnPh6WHsv4hrII6MPHn0LebbYo4ROJOf/BnYKlYwl6BJlkdXcPa7UzhO6 7kkH0shLm568RvD2zPAIumfsofJ6HTX8Yrq07q3rFDKHlB/8fzakIaaOt w==; X-IronPort-AV: E=McAfee;i="6400,9594,10409"; a="265683971" X-IronPort-AV: E=Sophos;i="5.92,274,1650956400"; d="scan'208";a="265683971" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2022 13:33:52 -0700 X-IronPort-AV: E=Sophos;i="5.92,274,1650956400"; d="scan'208";a="546785486" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2022 13:33:45 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oCS0L-001JGB-0F; Fri, 15 Jul 2022 23:33:41 +0300 Date: Fri, 15 Jul 2022 23:33:40 +0300 From: Andy Shevchenko To: Vladimir Oltean Cc: Russell King , Andrew Lunn , Heiner Kallweit , Alexandre Belloni , Alvin __ipraga , Claudiu Manoil , Daniel Scally , "David S. Miller" , DENG Qingfang , Eric Dumazet , Florian Fainelli , George McCollister , Greg Kroah-Hartman , Hauke Mehrtens , Heikki Krogerus , Jakub Kicinski , Kurt Kanzenbach , Landen Chao , Linus Walleij , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Matthias Brugger , netdev@vger.kernel.org, Paolo Abeni , "Rafael J. Wysocki" , Sakari Ailus , Sean Wang , UNGLinuxDriver@microchip.com, Vivien Didelot , Woojung Huh , Marek =?iso-8859-1?Q?Beh=FAn?= Subject: Re: [PATCH net-next 2/6] software node: allow named software node to be created Message-ID: References: <20220715201715.foea4rifegmnti46@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220715201715.foea4rifegmnti46@skbuf> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jul 15, 2022 at 11:17:15PM +0300, Vladimir Oltean wrote: > On Fri, Jul 15, 2022 at 10:57:55PM +0300, Andy Shevchenko wrote: > > On Fri, Jul 15, 2022 at 05:01:32PM +0100, Russell King wrote: > > > From: Vladimir Oltean > > > > > > Allow a named software node to be created, which is needed for software > > > nodes for a fixed-link specification for DSA. > > > > In general I have no objection, but what's worrying me is a possibility to > > collide in namespace. With the current code the name is generated based on > > unique IDs, how can we make this one more robust? > > Could you be more clear about the exact concern? Each software node can be created with a name. The hierarchy should be unique, means that there can't be two or more nodes with the same path (like on file system or more specifically here, Device Tree). Allowing to pass names we may end up with the situation when it will be a path collision. Yet, the static names are easier to check, because one may run `git grep ...` or coccinelle script to see what's in the kernel. -- With Best Regards, Andy Shevchenko