From: Ido Schimmel <idosch@nvidia.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, edumazet@google.com, mlxsw@nvidia.com,
saeedm@nvidia.com, moshe@nvidia.com, tariqt@nvidia.com
Subject: Re: [patch net-next 6/9] mlxsw: convert driver to use unlocked devlink API during init/fini
Date: Sun, 17 Jul 2022 10:36:20 +0300 [thread overview]
Message-ID: <YtO79H0VleQHfMUC@shredder> (raw)
In-Reply-To: <20220716110241.3390528-7-jiri@resnulli.us>
On Sat, Jul 16, 2022 at 01:02:38PM +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@nvidia.com>
>
> Prepare for devlink reload being called with devlink->lock held and
> convert the mlxsw driver to use unlocked devlink API during init and
> fini flows. Take devl_lock() in reload_down() and reload_up() ops in the
> meantime before reload cmd is converted to take the lock itself.
>
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>
It is getting hard to review changes in mlxsw_core_bus_device_register()
and mlxsw_core_bus_device_unregister() with all these reload checks.
Probably best if I convert it to something similar to netdevsim's
implementation after the devlink overhaul.
next prev parent reply other threads:[~2022-07-17 7:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-16 11:02 [patch net-next 0/9] devlink: prepare mlxsw and netdevsim for locked reload Jiri Pirko
2022-07-16 11:02 ` [patch net-next 1/9] net: devlink: avoid false DEADLOCK warning reported by lockdep Jiri Pirko
2022-07-16 11:02 ` [patch net-next 2/9] net: devlink: add unlocked variants of devling_trap*() functions Jiri Pirko
2022-07-16 11:02 ` [patch net-next 3/9] net: devlink: add unlocked variants of devlink_resource*() functions Jiri Pirko
2022-07-16 11:02 ` [patch net-next 4/9] net: devlink: add unlocked variants of devlink_sb*() functions Jiri Pirko
2022-07-16 11:02 ` [patch net-next 5/9] net: devlink: add unlocked variants of devlink_dpipe*() functions Jiri Pirko
2022-07-16 11:02 ` [patch net-next 6/9] mlxsw: convert driver to use unlocked devlink API during init/fini Jiri Pirko
2022-07-17 7:36 ` Ido Schimmel [this message]
2022-07-16 11:02 ` [patch net-next 7/9] net: devlink: add unlocked variants of devlink_region_create/destroy() functions Jiri Pirko
2022-07-16 11:02 ` [patch net-next 8/9] netdevsim: convert driver to use unlocked devlink API during init/fini Jiri Pirko
2022-07-16 11:02 ` [patch net-next 9/9] net: devlink: remove unused locked functions Jiri Pirko
2022-07-19 3:40 ` [patch net-next 0/9] devlink: prepare mlxsw and netdevsim for locked reload patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtO79H0VleQHfMUC@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).