From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8503CCA481 for ; Mon, 18 Jul 2022 18:59:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233992AbiGRS7j (ORCPT ); Mon, 18 Jul 2022 14:59:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232986AbiGRS7i (ORCPT ); Mon, 18 Jul 2022 14:59:38 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1A632B267; Mon, 18 Jul 2022 11:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658170777; x=1689706777; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=TIEQ4MTYN/3mHVFEK8QSYRaebmDVBch4wfEANQ4Z+F4=; b=OdAZMs5/FV9r4rM3kel/TrlnhkFPe49hMTYeGBKjIwHkeEq2hVoxu6sN ov8KI5oZYP1m13BZEAG3UYBOKybImL2Cuq0HFUSoxKVUG+FVIv8ayDBsz O6SOLBfyAnpdqAt8GufkKSiEgD3EpZjhK+OPzfhIWw3trXG/aHK49AVSi Z/rzcf50beDz08rRbgxgRj/bls8kGC4NVBPp4WKAQXTczSwnwdByKE1eC Uy95zE1/pvG5L1eV8pUQBjXNRCWBNU5SD4WBqOcTJC0OZsjdcnwyDOfnz xhmbThAShT0LJ58bh0dHBmFEittdEeGBsb7+CmG4T5JuSmRA81dXbJorZ A==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="287446628" X-IronPort-AV: E=Sophos;i="5.92,281,1650956400"; d="scan'208";a="287446628" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 11:59:37 -0700 X-IronPort-AV: E=Sophos;i="5.92,281,1650956400"; d="scan'208";a="700140775" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 11:59:30 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oDVxl-001OP6-31; Mon, 18 Jul 2022 21:59:25 +0300 Date: Mon, 18 Jul 2022 21:59:25 +0300 From: Andy Shevchenko To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexandre Belloni , Alvin __ipraga , Claudiu Manoil , Daniel Scally , "David S. Miller" , DENG Qingfang , Eric Dumazet , Florian Fainelli , George McCollister , Greg Kroah-Hartman , Hauke Mehrtens , Heikki Krogerus , Jakub Kicinski , Kurt Kanzenbach , Landen Chao , Linus Walleij , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Matthias Brugger , netdev@vger.kernel.org, Paolo Abeni , "Rafael J. Wysocki" , Sakari Ailus , Sean Wang , UNGLinuxDriver@microchip.com, Vivien Didelot , Vladimir Oltean , Woojung Huh , Marek =?iso-8859-1?Q?Beh=FAn?= Subject: Re: [PATCH net-next 5/6] net: dsa: use swnode fixed-link if using default params Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jul 15, 2022 at 10:36:29PM +0100, Russell King (Oracle) wrote: > On Fri, Jul 15, 2022 at 11:11:18PM +0300, Andy Shevchenko wrote: > > On Fri, Jul 15, 2022 at 05:01:48PM +0100, Russell King (Oracle) wrote: ... > > > Co-developed by Vladimir Oltean and myself. > > > > Why not to use > > > > Co-developed-by: Vladimir Oltean > > Ah, that's an official thing. Thanks. Yep, it's even documented in Submitting Patches. ... > > > + phy_node = of_parse_phandle(dn, "phy-handle", 0); > > > > fwnode in the name, why not to use fwnode APIs? > > > > fwnode_find_reference(); > > Marcin has a series converting DSA to use fwnode things - currently DSA > does not support ACPI, so converting it to fwnode doesn't make that much > sese until the proper ACPI patches get merged, which have now been > rebased on this series by Marcin in the expectation that these patches > would be merged... so I don't want to tred on Marcin's feet on that. But it's normal development process... Anyway, it seems to me that you are using fwnode out of that (with the exception of one call). To me it looks that you add a work to him, rather than making his life easier, since you know ahead that this is going to be converted. -- With Best Regards, Andy Shevchenko