Netdev List
 help / color / mirror / Atom feed
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
	linux-sctp@vger.kernel.org, davem@davemloft.net, kuba@kernel.org
Subject: Re: [PATCH net] Documentation: fix sctp_wmem in ip-sysctl.rst
Date: Tue, 19 Jul 2022 15:49:06 -0300	[thread overview]
Message-ID: <Ytb8ouxpPfV4MHru@t14s.localdomain> (raw)
In-Reply-To: <0ad4093257791efe9651303b91ece0de244aafa4.1658166896.git.lucien.xin@gmail.com>

On Mon, Jul 18, 2022 at 01:54:56PM -0400, Xin Long wrote:
> Since commit 1033990ac5b2 ("sctp: implement memory accounting on tx path"),
> SCTP has supported memory accounting on tx path where 'sctp_wmem' is used
> by sk_wmem_schedule(). So we should fix the description for this option in
> ip-sysctl.rst accordingly.
> 
> Fixes: 1033990ac5b2 ("sctp: implement memory accounting on tx path")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
>  Documentation/networking/ip-sysctl.rst | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
> index 0e58001f8580..b7db2e5e5cc5 100644
> --- a/Documentation/networking/ip-sysctl.rst
> +++ b/Documentation/networking/ip-sysctl.rst
> @@ -2870,7 +2870,14 @@ sctp_rmem - vector of 3 INTEGERs: min, default, max
>  	Default: 4K
>  
>  sctp_wmem  - vector of 3 INTEGERs: min, default, max
> -	Currently this tunable has no effect.
> +	Only the first value ("min") is used, "default" and "max" are
> +	ignored.
> +
> +	min: Minimal size of send buffer used by SCTP socket.

I'm not a native English speaker, but this seems better:
"Minimum size of send buffer that can be used by an SCTP socket."

> +	It is guaranteed to each SCTP socket (but not association) even
> +	under moderate memory pressure.
> +
> +	Default: 4K
>  
>  addr_scope_policy - INTEGER
>  	Control IPv4 address scoping - draft-stewart-tsvwg-sctp-ipv4-00
> -- 
> 2.31.1
> 

  reply	other threads:[~2022-07-19 18:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18 17:54 [PATCH net] Documentation: fix sctp_wmem in ip-sysctl.rst Xin Long
2022-07-19 18:49 ` Marcelo Ricardo Leitner [this message]
2022-07-20 17:03   ` Xin Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ytb8ouxpPfV4MHru@t14s.localdomain \
    --to=marcelo.leitner@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox