From: Andrew Lunn <andrew@lunn.ch>
To: Antonio Quartulli <antonio@openvpn.net>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/1] net: introduce OpenVPN Data Channel Offload (ovpn-dco)
Date: Tue, 19 Jul 2022 17:25:57 +0200 [thread overview]
Message-ID: <YtbNBUZ0Kz7pgmWK@lunn.ch> (raw)
In-Reply-To: <20220719014704.21346-2-antonio@openvpn.net>
> +static void ovpn_get_drvinfo(struct net_device *dev,
> + struct ethtool_drvinfo *info)
> +{
> + strscpy(info->driver, DRV_NAME, sizeof(info->driver));
> + strscpy(info->version, DRV_VERSION, sizeof(info->version));
> + strscpy(info->bus_info, "ovpn", sizeof(info->bus_info));
version is generally considered useless information if it comes from
the driver. You have no idea if this is version 42 in net-next, or
some backported version in an enterprise kernel with lots of out of
tree patches. The driver is not standalone, it runs inside the
kernel. So in order to understand a bug report, you need to know what
kernel it is. If you don't fill in version, the core will with the
kernel version, which is much more useful.
Andrew
next prev parent reply other threads:[~2022-07-19 15:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 1:47 [RFC 0/1] Introducing OpenVPN Data Channel Offload Antonio Quartulli
2022-07-19 1:47 ` [RFC 1/1] net: introduce OpenVPN Data Channel Offload (ovpn-dco) Antonio Quartulli
2022-07-19 15:19 ` Andrew Lunn
2022-07-19 15:21 ` Antonio Quartulli
2022-07-19 15:25 ` Andrew Lunn [this message]
2022-07-28 7:41 ` Antonio Quartulli
2022-07-28 13:07 ` Andrew Lunn
2022-07-28 13:16 ` Antonio Quartulli
2022-08-03 15:42 ` Stephen Hemminger
2022-08-03 15:48 ` Antonio Quartulli
2022-08-03 16:19 ` Stephen Hemminger
2022-08-04 7:34 ` Antonio Quartulli
2022-07-28 16:28 ` Jakub Kicinski
2022-07-28 19:16 ` Antonio Quartulli
2022-07-19 15:37 ` Andrew Lunn
2022-07-28 7:44 ` Antonio Quartulli
2022-07-28 13:12 ` Andrew Lunn
2022-08-03 15:31 ` [RFC v2] " Antonio Quartulli
2022-08-12 18:34 ` Sergey Ryazanov
2022-08-12 18:44 ` Stephen Hemminger
2022-08-30 22:35 ` Sergey Ryazanov
2022-08-12 21:05 ` Antonio Quartulli
2022-08-31 3:15 ` Sergey Ryazanov
2022-09-09 20:40 ` Antonio Quartulli
2022-09-13 0:49 ` Sergey Ryazanov
2022-08-03 16:04 ` [RFC 1/1] " Joe Perches
2022-08-04 7:35 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtbNBUZ0Kz7pgmWK@lunn.ch \
--to=andrew@lunn.ch \
--cc=antonio@openvpn.net \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).