From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 549D7C43334 for ; Wed, 20 Jul 2022 11:35:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234060AbiGTLf2 (ORCPT ); Wed, 20 Jul 2022 07:35:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231281AbiGTLf0 (ORCPT ); Wed, 20 Jul 2022 07:35:26 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A05D1838B; Wed, 20 Jul 2022 04:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hoc3SZ+a6cRMEV4dB3AWnbJTTC3nfLgS/xRzs04z7hg=; b=W3bqgC4atmjinJIsHmrzqz0PRG VdQarQ+8WG5T7XWBl5k/gL4YP+gOSjn0Vuidw1joFx6mX3gatujP8OabM9KsFfCZ223wTVwLM9QCp 16DkFRkXeAj4sU/QaaAq9S2pYTgRu9VO80LTELaQum+YJJGuoGg7fQc7zFrq1256eXhbZ5iPOdVol DCQS9Mp7tc8+tsMYQMmiiTrQwQbx6x3wgbSFxtTFucTZkCalFScuqERAA8zi7duCrtgVoP2po7Vy2 sm/iZtNbj1NJsTA5p94NeKmcKuBcuEAvW/u7YnQ58QmnYK7WvTnx+UNFsHD7RI78DP8dBJdaybtGo B39z/dhQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:33460) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oE7z7-00042D-I7; Wed, 20 Jul 2022 12:35:21 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oE7z5-0003ro-9G; Wed, 20 Jul 2022 12:35:19 +0100 Date: Wed, 20 Jul 2022 12:35:19 +0100 From: "Russell King (Oracle)" To: Sean Anderson Cc: netdev@vger.kernel.org, Andrew Lunn , Heiner Kallweit , Alexandru Marginean , Paolo Abeni , "David S . Miller" , linux-kernel@vger.kernel.org, Vladimir Oltean , Eric Dumazet , Jakub Kicinski Subject: Re: [PATCH v2 10/11] net: phy: aquantia: Add some additional phy interfaces Message-ID: References: <20220719235002.1944800-1-sean.anderson@seco.com> <20220719235002.1944800-11-sean.anderson@seco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220719235002.1944800-11-sean.anderson@seco.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 19, 2022 at 07:50:00PM -0400, Sean Anderson wrote: > +/* The following registers all have similar layouts; first the registers... */ > +#define VEND1_GLOBAL_CFG_10M 0x0310 > +#define VEND1_GLOBAL_CFG_100M 0x031b > +#define VEND1_GLOBAL_CFG_1G 0x031c > +#define VEND1_GLOBAL_CFG_2_5G 0x031d > +#define VEND1_GLOBAL_CFG_5G 0x031e > +#define VEND1_GLOBAL_CFG_10G 0x031f > +/* ...and now the fields */ > +#define VEND1_GLOBAL_CFG_RATE_ADAPT GENMASK(8, 7) > +#define VEND1_GLOBAL_CFG_RATE_ADAPT_NONE 0 > +#define VEND1_GLOBAL_CFG_RATE_ADAPT_USX 1 > +#define VEND1_GLOBAL_CFG_RATE_ADAPT_PAUSE 2 > + Shouldn't these definitions be in patch 11? They don't appear to be used in this patch. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!