* [PATCH net-next] mlxsw: fix devlink use after frees
@ 2022-07-22 6:32 Dan Carpenter
2022-07-22 9:36 ` Ido Schimmel
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-07-22 6:32 UTC (permalink / raw)
To: Ido Schimmel, Jiri Pirko
Cc: Petr Machata, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, kernel-janitors
Unlock "devlink" before freeing it instead of after.
Fixes: 72a4c8c94efa ("mlxsw: convert driver to use unlocked devlink API during init/fini")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/mellanox/mlxsw/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c
index 61eb96b93889..1b61bc8f59a2 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/core.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/core.c
@@ -2296,8 +2296,8 @@ void mlxsw_core_bus_device_unregister(struct mlxsw_core *mlxsw_core,
devl_resources_unregister(devlink);
mlxsw_core->bus->fini(mlxsw_core->bus_priv);
if (!reload) {
- devlink_free(devlink);
devl_unlock(devlink);
+ devlink_free(devlink);
}
return;
@@ -2305,8 +2305,8 @@ void mlxsw_core_bus_device_unregister(struct mlxsw_core *mlxsw_core,
reload_fail_deinit:
mlxsw_core_params_unregister(mlxsw_core);
devl_resources_unregister(devlink);
- devlink_free(devlink);
devl_unlock(devlink);
+ devlink_free(devlink);
}
EXPORT_SYMBOL(mlxsw_core_bus_device_unregister);
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] mlxsw: fix devlink use after frees
2022-07-22 6:32 [PATCH net-next] mlxsw: fix devlink use after frees Dan Carpenter
@ 2022-07-22 9:36 ` Ido Schimmel
0 siblings, 0 replies; 2+ messages in thread
From: Ido Schimmel @ 2022-07-22 9:36 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jiri Pirko, Petr Machata, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, kernel-janitors
On Fri, Jul 22, 2022 at 09:32:40AM +0300, Dan Carpenter wrote:
> Unlock "devlink" before freeing it instead of after.
>
> Fixes: 72a4c8c94efa ("mlxsw: convert driver to use unlocked devlink API during init/fini")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for the patch, but a fix was already posted yesterday:
https://patchwork.kernel.org/project/netdevbpf/patch/20220721142424.3975704-1-jiri@resnulli.us/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-22 9:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-22 6:32 [PATCH net-next] mlxsw: fix devlink use after frees Dan Carpenter
2022-07-22 9:36 ` Ido Schimmel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).