From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Louis Goyard <louis.goyard@hashi.re>
Cc: Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com, Coiby Xu <coiby.xu@gmail.com>,
netdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: qlge: fix indentation
Date: Wed, 27 Jul 2022 08:42:00 +0200 [thread overview]
Message-ID: <YuDeOFTWAxWsYvYa@kroah.com> (raw)
In-Reply-To: <0e60fe4b-5bc6-19bb-a061-23acbfa606c4@hashi.re>
On Fri, Jul 15, 2022 at 04:30:37PM +0200, Louis Goyard wrote:
> From: Louis Goyard <louis.goyard@hashi.re>
>
> Adhere to linux coding style. Reported by checkpatch:
> WARNING: suspect code indent for conditional statements (16, 32)
>
> Signed-off-by: Louis Goyard <louis.goyard@hashi.re>
> ---
> drivers/staging/qlge/qlge_main.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/qlge/qlge_main.c
> b/drivers/staging/qlge/qlge_main.c
> index 1a378330d775..8eb0048c596d 100644
> --- a/drivers/staging/qlge/qlge_main.c
> +++ b/drivers/staging/qlge/qlge_main.c
> @@ -3008,9 +3008,9 @@ static int qlge_start_rx_ring(struct qlge_adapter
> *qdev, struct rx_ring *rx_ring
> base_indirect_ptr = rx_ring->lbq.base_indirect;
>
> for (page_entries = 0; page_entries <
> - MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> - base_indirect_ptr[page_entries] =
> - cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> + MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> + base_indirect_ptr[page_entries] =
> + cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> cqicb->lbq_addr = cpu_to_le64(rx_ring->lbq.base_indirect_dma);
> cqicb->lbq_buf_size =
> cpu_to_le16(QLGE_FIT16(qdev->lbq_buf_size));
> @@ -3023,9 +3023,9 @@ static int qlge_start_rx_ring(struct qlge_adapter
> *qdev, struct rx_ring *rx_ring
> base_indirect_ptr = rx_ring->sbq.base_indirect;
>
> for (page_entries = 0; page_entries <
> - MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> - base_indirect_ptr[page_entries] =
> - cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> + MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> + base_indirect_ptr[page_entries] =
> + cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> cqicb->sbq_addr =
> cpu_to_le64(rx_ring->sbq.base_indirect_dma);
> cqicb->sbq_buf_size = cpu_to_le16(SMALL_BUFFER_SIZE);
> --
> 2.37.1
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
and can not be applied. Please read the file,
Documentation/email-clients.txt in order to fix this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
prev parent reply other threads:[~2022-07-27 6:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 14:30 [PATCH] staging: qlge: fix indentation Louis Goyard
2022-07-27 6:42 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuDeOFTWAxWsYvYa@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=coiby.xu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=louis.goyard@hashi.re \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).