From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B198C00144 for ; Fri, 29 Jul 2022 06:30:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234723AbiG2Gao (ORCPT ); Fri, 29 Jul 2022 02:30:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234760AbiG2Gam (ORCPT ); Fri, 29 Jul 2022 02:30:42 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06DC733E1F for ; Thu, 28 Jul 2022 23:30:40 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id fy29so6776399ejc.12 for ; Thu, 28 Jul 2022 23:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bWSzqeEFY473AbdSEUh9RG/IE8UaIJYtfYVbaWkdYLI=; b=Wj6z8JseaJL8shZrXFYt9zLi8frLlWM7VjSpt8ww4nN/PTi7fMQtSunYnSvW5IJJco n4nbWOvksWH91xNv9Cz+P3ZTMdxyen7JrPlO2p5p49Ho7M8ZvFXM4JMFD8SxZtGD0mj2 mnK3VuVfyhrZc7D6SlEb/uy54GLUFIKRPD0W4SpbPKFe/zsrqf79RvwR/B2GadalG61g 4kEr6GJxZIBX4XfzfId4qcpTUGuEhoqVIk7+xmBPo8ia8apUVKm1Zl6mykaQfkcUY5QT LXDQuN+yy3zf3XdOXUhx6oNd8EN49WZRTU7oLW0V/iyIxWirTnxjUzo3GF8LLZMBXIfx B6Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bWSzqeEFY473AbdSEUh9RG/IE8UaIJYtfYVbaWkdYLI=; b=l0bhMtXM9L/69ctvVJQF1XL6OotDjgUNPuFNzgtXo+rIhqg/AnypzdRcP9SVWXeW0O BGxRvZ1mWcVS8QIuZtPZvqA3q1zsIqO8VHh2qFrBRv2/iSNDEF/GDJHerNJbpVnejPtV N3ZPKSv34xsKXxcgJBABu4ryhgPzhwjTXzcxD3xOXs8KTCRhWIR51Nv8yDTiznqU0zGx kxKelHjJdEBBp2kFirfDh0Vsom8/UIO5Fwi36OSIXRcpjVkOL4dsEA5+aJfICn/pST33 DygWNWcwD+LARdtLm9t7mk+bJiEku8p6j5UarohrIc0ZtNOXND/yMGAPPuqVHzkHmbHO rWFg== X-Gm-Message-State: AJIora/R+4+p9MF8vj3RmJsHCXUipAVy3YweGXohPRyoHuayeLlTr1pt YwR0UcgOim6F+4XyyfigYor0v/MyFE2L1eNX X-Google-Smtp-Source: AGRyM1tXSeZepdVJUwVji9mBkqKmaR2txlk7uUtwvQR5UHYc18vHGUX5u160UpPWMkXHv48FY6QMKg== X-Received: by 2002:a17:907:2889:b0:72b:50c8:c703 with SMTP id em9-20020a170907288900b0072b50c8c703mr1719190ejc.694.1659076238249; Thu, 28 Jul 2022 23:30:38 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id kz21-20020a17090777d500b0072b6d91b056sm1289871ejc.142.2022.07.28.23.30.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 23:30:37 -0700 (PDT) Date: Fri, 29 Jul 2022 08:30:35 +0200 From: Jiri Pirko To: Jakub Kicinski Cc: Li zeming , jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched/net/act: Remove temporary state variables Message-ID: References: <20220727094146.5990-1-zeming@nfschina.com> <20220728201556.230b9efd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220728201556.230b9efd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fri, Jul 29, 2022 at 05:15:56AM CEST, kuba@kernel.org wrote: >On Wed, 27 Jul 2022 17:41:46 +0800 Li zeming wrote: >> The temporary variable ret could be removed and the corresponding state >> can be directly returned. > >How many case like this are there in the kernel? >What tool are you using to find this? >We should focus on creating CI tools which can help catch instances of >this pattern in new code before it gets added, rather than cleaning up >old code. It just makes backports harder for hardly any gain. What backports do you have in mind exactly?