From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Li zeming <zeming@nfschina.com>,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/net/act: Remove temporary state variables
Date: Fri, 29 Jul 2022 09:00:07 +0200 [thread overview]
Message-ID: <YuOFd2oqA1Cbl+at@nanopsycho> (raw)
In-Reply-To: <20220728235121.43bedc43@kernel.org>
Fri, Jul 29, 2022 at 08:51:21AM CEST, kuba@kernel.org wrote:
>On Fri, 29 Jul 2022 08:30:35 +0200 Jiri Pirko wrote:
>>> How many case like this are there in the kernel?
>>> What tool are you using to find this?
>>> We should focus on creating CI tools which can help catch instances of
>>> this pattern in new code before it gets added, rather than cleaning up
>>> old code. It just makes backports harder for hardly any gain.
>>
>> What backports do you have in mind exactly?
>
>Code backports. I don't understand the question.
Code backports of what where?
Are you talking about:
1) mainline kernels
2) distrubutions kernels? Or even worse, in-house kernels of companies?
If 2), I believe it is not relevant for the upstream discussion, at all.
>There's little benefit and we're getting multiple such patches a day.
next prev parent reply other threads:[~2022-07-29 7:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 9:41 [PATCH] sched/net/act: Remove temporary state variables Li zeming
2022-07-29 3:15 ` Jakub Kicinski
2022-07-29 6:30 ` Jiri Pirko
2022-07-29 6:51 ` Jakub Kicinski
2022-07-29 7:00 ` Jiri Pirko [this message]
2022-07-29 7:18 ` Jakub Kicinski
2022-07-29 8:11 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuOFd2oqA1Cbl+at@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
--cc=zeming@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).