From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD47C19F2A for ; Fri, 29 Jul 2022 21:18:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238888AbiG2VSL (ORCPT ); Fri, 29 Jul 2022 17:18:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbiG2VSL (ORCPT ); Fri, 29 Jul 2022 17:18:11 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9940676E95 for ; Fri, 29 Jul 2022 14:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=2M83f9MsZsqzBuEKGOW1/VhUGI8UI9FW4n3Owwp/6EY=; b=n2aZmblTafvdBSv8Xm+5UGWw1V 5NEgphu1+t+actQWC4HHJwRLug9qfS0qalvygBxHDlVsIhaCioouvwjTdvlnhJkr42IfjdDVIf0KV lPTYmWpUXi/EA1jwLpzIrkAjrstOL0mn7POhw+rRpUBCW9tzc8+EpyuTdDpKVP+nkMKU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oHXMp-00ByGO-7w; Fri, 29 Jul 2022 23:17:55 +0200 Date: Fri, 29 Jul 2022 23:17:55 +0200 From: Andrew Lunn To: Marcin Wojtas Cc: Vladimir Oltean , netdev , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vivien Didelot , Florian Fainelli , Oleksij Rempel , Christian Marangi , John Crispin , Kurt Kanzenbach , Mans Rullgard , Arun Ramadoss , Woojung Huh , "UNGLinuxDriver@microchip.com" , Claudiu Manoil , Alexandre Belloni , George McCollister , DENG Qingfang , Sean Wang , Landen Chao , Matthias Brugger , Hauke Mehrtens , Martin Blumenstingl , Aleksander Jan Bajkowski , Alvin =?utf-8?Q?=C5=A0ipraga?= , Luiz Angelo Daros de Luca , Linus Walleij , Pawel Dembicki , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Geert Uytterhoeven , Russell King , Marek =?iso-8859-1?Q?Beh=FAn?= , Rob Herring , Frank Rowand , Tomasz Nowicki , Grzegorz Jaszczyk Subject: Re: [PATCH v2 net-next 4/4] net: dsa: validate that DT nodes of shared ports have the properties they need Message-ID: References: <20220729132119.1191227-1-vladimir.oltean@nxp.com> <20220729132119.1191227-5-vladimir.oltean@nxp.com> <20220729183444.jzr3eoj6xdumezwu@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > What I propose is to enforce more strictly an update of DT description > with a specified timeline, abandoning 'camps' idea and driver-specific > contents in the generic code. Regressions are the problem. We are supposed to be backwards compatible with older DT blobs. If we now say old DT blobs are invalid, and refuse to probe, we cause a regression. For some of the in kernel DT files using the mv88e6xxx i can make a good guess at what the missing properties are. However, i'm bound to guess wrong at some point, and cause a regression. So we could change just those we can test. But at some point, the other blobs are going to fail the enforces checks and cause a regression anyway. And what about out of tree blobs? Probably OpenWRT have some. Do we want to cause them to regress? Andrew