From: Andrew Lunn <andrew@lunn.ch>
To: Oliver Neukum <oneukum@suse.com>
Cc: hayeswang@realtek.com, netdev@vger.kernel.org
Subject: Re: [RFC] r8152: pass through needs to be singular
Date: Tue, 2 Aug 2022 15:31:32 +0200 [thread overview]
Message-ID: <YuknNESeYxCjcPrD@lunn.ch> (raw)
In-Reply-To: <34f7cb15-91e8-e92c-7dcd-f5b28724df92@suse.com>
> True. Nevertheless, do we really want to say that we dislike a design
> so much that we are not fixing bugs?
I'm not sure we can fix it. Part of that long thread about why this
whole concept is broken is that we have no idea which interface is the
one which should give the MAC address to. If we change it to only give
out the MAC address once, all we really do is change it from one bug
to another bug.
> > What exactly is your problem which you are trying to fix?
> Adressing the comment Hayes made when reset_resume() was fixed
> from a deadlock, that it still assigns wrong MACs. I feel that
> before I fix keeping the correct address I better make sure the
> MAC is sane in the first place.
I would say that reset_resume() should restore whatever the MAC
address was before the suspend. It does not matter if the MAC address
is not unique. As far as i know, the kernel never prevents the user
assigning the same MAC address on multiple interfaces via ip link set.
So it could actually be a user choice.
Andrew
next prev parent reply other threads:[~2022-08-02 13:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 19:18 [RFC] r8152: pass through needs to be singular Oliver Neukum
2022-07-28 22:11 ` Andrew Lunn
2022-08-02 10:52 ` Oliver Neukum
2022-08-02 13:31 ` Andrew Lunn [this message]
2022-08-04 9:24 ` Oliver Neukum
2022-08-04 13:24 ` Andrew Lunn
2022-08-04 13:29 ` Oliver Neukum
2022-08-04 14:31 ` Andrew Lunn
2022-08-03 3:48 ` Hayes Wang
2022-08-04 8:57 ` Oliver Neukum
2022-08-08 7:04 ` Hayes Wang
2022-08-23 7:53 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuknNESeYxCjcPrD@lunn.ch \
--to=andrew@lunn.ch \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).