From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E2B2C00140 for ; Tue, 2 Aug 2022 13:31:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235854AbiHBNbn (ORCPT ); Tue, 2 Aug 2022 09:31:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233142AbiHBNbm (ORCPT ); Tue, 2 Aug 2022 09:31:42 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE61E1707C for ; Tue, 2 Aug 2022 06:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=94Klh7ZbIlEablWPYAvdogA44/E1XeUWPv6lShgFnHs=; b=eB8eO756asBCbwna9uKnNexwsS 3V3J1JWZMtuDXNk+CSBEsv7pG2poZNfee4MXreFRMsnl3U4j+A8ySF9ew8DWZlYUZPr2RrofF3J7p 9dJ38dSRtZrLHWA1OZO29wf8f68tG52EoFI3FhxJOPxb6LDXlHDpYDZq/9GX0z/4F7GU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oIrzg-00CGCA-NR; Tue, 02 Aug 2022 15:31:32 +0200 Date: Tue, 2 Aug 2022 15:31:32 +0200 From: Andrew Lunn To: Oliver Neukum Cc: hayeswang@realtek.com, netdev@vger.kernel.org Subject: Re: [RFC] r8152: pass through needs to be singular Message-ID: References: <20220728191851.30402-1-oneukum@suse.com> <34f7cb15-91e8-e92c-7dcd-f5b28724df92@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <34f7cb15-91e8-e92c-7dcd-f5b28724df92@suse.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > True. Nevertheless, do we really want to say that we dislike a design > so much that we are not fixing bugs? I'm not sure we can fix it. Part of that long thread about why this whole concept is broken is that we have no idea which interface is the one which should give the MAC address to. If we change it to only give out the MAC address once, all we really do is change it from one bug to another bug. > > What exactly is your problem which you are trying to fix? > Adressing the comment Hayes made when reset_resume() was fixed > from a deadlock, that it still assigns wrong MACs. I feel that > before I fix keeping the correct address I better make sure the > MAC is sane in the first place. I would say that reset_resume() should restore whatever the MAC address was before the suspend. It does not matter if the MAC address is not unique. As far as i know, the kernel never prevents the user assigning the same MAC address on multiple interfaces via ip link set. So it could actually be a user choice. Andrew