Re: [PATCH v2 04/13] soc: bcm: brcmstb: Document panic notifier action and remove useless header

Florian Fainelli
2022-07-20T23:00:20Z

On Tue, 19 Jul 2022 16:53:17 -0300, "Guilherme G. Piccoli" <gpiccoli@igalia.com> wrote:
> The panic notifier of this driver is very simple code-wise, just a
> memory write to a special position with some numeric code. But this
> is not clear from the semantic point-of-view, and there is no public
> documentation about that either.
>
> After discussing this in the mailing-lists [0] and having Florian
> explained it very well, document that in the code for the future
> generations asking the same questions. Also, while at it, remove
> a useless header.
>
> [0] https://lore.kernel.org/lkml/781cafb0-8d06-8b56-907a-5175c2da196a@gmail.com
>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: Doug Berger <opendmb@gmail.com>
> Cc: Justin Chen <justinpopo6@gmail.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Markus Mayer <mmayer@broadcom.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/drivers/next, thanks!
--
Florian