Re: [PATCH v2 09/13] notifier: Show function names on notifier routines if DEBUG_NOTIFIERS is set

Arjan van de Ven
2022-07-19T20:33:19Z

On 7/19/2022 12:53 PM, Guilherme G. Piccoli wrote:
> Currently we have a debug infrastructure in the notifiers file, but
> it's very simple/limited. Extend it by:
>
> (a) Showing all registered/unregistered notifiers' callback names;

I'm not yet convinced that this is the right direction.
The original intent for this "debug" feature was to be lightweight enough that it could run in production, since at the time, rootkits
liked to clobber/hijack notifiers and there were also some other signs of corruption at the time.

By making something print (even at pr_info) for what are probably frequent non-error operations, you turn something that is light
into something that's a lot more heavy and generally that's not a great idea... it'll be a performance surprise.