Re: [PATCH v2 10/13] EDAC/altera: Skip the panic notifier if kdump is loaded

Guilherme G. Piccoli
2022-08-17T21:57:55Z

On 17/08/2022 18:46, Borislav Petkov wrote:
> On Wed, Aug 17, 2022 at 06:39:07PM -0300, Guilherme G. Piccoli wrote:
>> Sorry for the confusion, let me try to be a bit more clear:
>
> I think you're missing the point. Lemme try again:
>
> You *absolutely* must log those errors because they're important. It
> doesn't matter if this is done in a panic notifier and you're changing
> that whole shebang or through some other magic.
>
> If you do, then this driver needs to *still* *log* those fatal errors -
> regardless through a panic notifier or some novel contraption it wants
> to use.
>
> So if you want to change the panic notifiers, you *must* make sure those
> errors still do get logged.
>
> Better?
>

Boris, I understand the importance of the logs, for sure!

But do you agree that currently, in case of a kdump, that information
*is not collected*, with our without my patch?