From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
Beniamin Sandu <beniaminsandu@gmail.com>,
hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sfp: use simplified HWMON_CHANNEL_INFO macro
Date: Thu, 18 Aug 2022 03:21:53 +0200 [thread overview]
Message-ID: <Yv2UMcVUSwiaFyH6@lunn.ch> (raw)
In-Reply-To: <20220817101916.10dec387@kernel.org>
On Wed, Aug 17, 2022 at 10:19:16AM -0700, Jakub Kicinski wrote:
> On Wed, 17 Aug 2022 17:12:24 +0100 Russell King (Oracle) wrote:
> > On Wed, Aug 17, 2022 at 08:54:29AM -0700, Jakub Kicinski wrote:
> > > On Sat, 13 Aug 2022 23:46:58 +0300 Beniamin Sandu wrote:
> > > > This makes the code look cleaner and easier to read.
> > >
> > > Last call for reviews..
> >
> > I had a quick look and couldn't see anything obviously wrong, but then
> > I'm no expert with the hwmon code.
>
> That makes two of us, good enough! :) Thanks for taking a look.
It would of been nice to Cc: the HWMON maintainer. His input would of
been just as valuable as a PHY Maintainer.
Andrew
next prev parent reply other threads:[~2022-08-18 1:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-13 20:46 [PATCH] net: sfp: use simplified HWMON_CHANNEL_INFO macro Beniamin Sandu
2022-08-17 15:54 ` Jakub Kicinski
2022-08-17 16:12 ` Russell King (Oracle)
2022-08-17 17:19 ` Jakub Kicinski
2022-08-18 1:21 ` Andrew Lunn [this message]
2022-08-18 2:19 ` Jakub Kicinski
2022-08-18 16:58 ` Guenter Roeck
2022-08-18 17:14 ` Jakub Kicinski
2022-08-17 17:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv2UMcVUSwiaFyH6@lunn.ch \
--to=andrew@lunn.ch \
--cc=beniaminsandu@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).