From: Andrew Lunn <andrew@lunn.ch>
To: Feiyang Chen <chris.chenfeiyang@gmail.com>
Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, Feiyang Chen <chenfeiyang@loongson.cn>,
zhangqing@loongson.cn, chenhuacai@loongson.cn,
netdev@vger.kernel.org, loongarch@lists.linux.dev
Subject: Re: [PATCH] stmmac: pci: Add LS7A support for dwmac-loongson
Date: Thu, 18 Aug 2022 04:19:02 +0200 [thread overview]
Message-ID: <Yv2hlkIpd8A66+iP@lunn.ch> (raw)
In-Reply-To: <20220816102537.33986-1-chenfeiyang@loongson.cn>
On Tue, Aug 16, 2022 at 06:25:37PM +0800, Feiyang Chen wrote:
> Current dwmac-loongson only support LS2K in the "probed with PCI and
> configured with DT" manner. We add LS7A support on which the devices
> are fully PCI (non-DT).
Please could you break this patch up into a number of smaller
patches. It is very hard to follow what you are changing here.
Ideally you want lots of small patches, each with a good commit
message, which are obviously correct.
Andrew
next prev parent reply other threads:[~2022-08-18 2:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 10:25 [PATCH] stmmac: pci: Add LS7A support for dwmac-loongson Feiyang Chen
2022-08-18 2:15 ` Andrew Lunn
2022-08-18 5:01 ` Feiyang Chen
2022-08-18 14:55 ` Andrew Lunn
2022-08-18 2:19 ` Andrew Lunn [this message]
2022-08-18 5:01 ` Feiyang Chen
2022-11-21 13:03 ` Xi Ruoyao
2022-11-22 1:06 ` Feiyang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv2hlkIpd8A66+iP@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=chenfeiyang@loongson.cn \
--cc=chenhuacai@loongson.cn \
--cc=chris.chenfeiyang@gmail.com \
--cc=joabreu@synopsys.com \
--cc=loongarch@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=zhangqing@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).