* cmd_sb_occ_show doesn't call dl_put_opts
@ 2022-08-05 20:18 Jacob Keller
2022-08-08 7:16 ` Jiri Pirko
0 siblings, 1 reply; 2+ messages in thread
From: Jacob Keller @ 2022-08-05 20:18 UTC (permalink / raw)
To: Jiri Pirko, netdev@vger.kernel.org
Hey Jiri,
I noticed while looking at implementing policy checking support in
devlink that the cmd_sb_occ_show calls dl_argv_parse but then doesn't
call dl_put_opts, so it doesn't seem to be sending any of the attributes
down to the kernel.
I am guessing this is not done on purpose, and is just an oversight,
caused by needing to send two different netlink messages.
It looks like the code could use a dl_argc check to determine whether to
use NLM_F_DUMP and call dl_put_opts to ensure the netlink attributes get
added..?
Thanks,
Jake
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: cmd_sb_occ_show doesn't call dl_put_opts
2022-08-05 20:18 cmd_sb_occ_show doesn't call dl_put_opts Jacob Keller
@ 2022-08-08 7:16 ` Jiri Pirko
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Pirko @ 2022-08-08 7:16 UTC (permalink / raw)
To: Jacob Keller; +Cc: Jiri Pirko, netdev@vger.kernel.org
Fri, Aug 05, 2022 at 10:18:22PM CEST, jacob.e.keller@intel.com wrote:
>Hey Jiri,
>
>I noticed while looking at implementing policy checking support in
>devlink that the cmd_sb_occ_show calls dl_argv_parse but then doesn't
>call dl_put_opts, so it doesn't seem to be sending any of the attributes
>down to the kernel.
>
>I am guessing this is not done on purpose, and is just an oversight,
>caused by needing to send two different netlink messages.
>
>It looks like the code could use a dl_argc check to determine whether to
>use NLM_F_DUMP and call dl_put_opts to ensure the netlink attributes get
>added..?
Correct. Currently we are doing dump all the time. Should be fixed.
>
>Thanks,
>Jake
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-08 7:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-05 20:18 cmd_sb_occ_show doesn't call dl_put_opts Jacob Keller
2022-08-08 7:16 ` Jiri Pirko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).