From: Hangbin Liu <liuhangbin@gmail.com>
To: Jonathan Toppins <jtoppins@redhat.com>
Cc: netdev@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net v2 1/2] selftests: include bonding tests into the kselftest infra
Date: Wed, 10 Aug 2022 11:56:44 +0800 [thread overview]
Message-ID: <YvMsfHf1HebcoQNp@Laptop-X1> (raw)
In-Reply-To: <d7902978499da81c6fa8bc530d16e2f71f84c0f1.1660098382.git.jtoppins@redhat.com>
On Tue, Aug 09, 2022 at 10:33:21PM -0400, Jonathan Toppins wrote:
> +++ b/tools/testing/selftests/drivers/net/bonding/bond-break-lacpdu-tx.sh
> @@ -0,0 +1,82 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0
> +
> +# Regression Test:
> +# Verify LACPDUs get transmitted after setting the MAC address of
> +# the bond.
> +#
> +# https://bugzilla.redhat.com/show_bug.cgi?id=2020773
> +#
> +# +---------+
> +# | fab-br0 |
> +# +---------+
> +# |
> +# +---------+
> +# | fbond |
> +# +---------+
> +# | |
> +# +------+ +------+
> +# |veth1 | |veth2 |
> +# +------+ +------+
> +#
> +# We use veths instead of physical interfaces
> +
> +set -e
> +#set -x
nit： maybe remove this debug comment when you post a new version?
Others looks good to me.
Thanks
Hangbin
next prev parent reply other threads:[~2022-08-10 3:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 2:33 [PATCH net v2 0/2] bonding: 802.3ad: fix no transmission of LACPDUs Jonathan Toppins
2022-08-10 2:33 ` [PATCH net v2 1/2] selftests: include bonding tests into the kselftest infra Jonathan Toppins
2022-08-10 3:56 ` Hangbin Liu [this message]
2022-08-10 2:33 ` [PATCH net v2 2/2] bonding: 802.3ad: fix no transmission of LACPDUs Jonathan Toppins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvMsfHf1HebcoQNp@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=jtoppins@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).